mbox series

[GIT,PULL] Please pull my kvm-ppc-fixes branch

Message ID 20170830062130.GD27329@fergus.ozlabs.ibm.com
State Accepted
Headers show
Series [GIT,PULL] Please pull my kvm-ppc-fixes branch | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc kvm-ppc-fixes

Message

Paul Mackerras Aug. 30, 2017, 6:21 a.m. UTC
Paolo,

Please do a pull from my kvm-ppc-fixes branch to get one more commit
for 4.13.  It adds mutual exclusion between list_add_rcu and
list_del_rcu calls on the kvm->arch.spapr_tce_tables list.  Without
this, userspace could potentially trigger corruption of the list and
cause a host crash or worse.

Thanks,
Paul.

The following changes since commit 47c5310a8dbe7c2cb9f0083daa43ceed76c257fa:

  KVM: PPC: Book3S: Fix race and leak in kvm_vm_ioctl_create_spapr_tce() (2017-08-25 11:08:57 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc kvm-ppc-fixes

for you to fetch changes up to edd03602d97236e8fea13cd76886c576186aa307:

  KVM: PPC: Book3S HV: Protect updates to spapr_tce_tables list (2017-08-30 14:59:31 +1000)

----------------------------------------------------------------
Paul Mackerras (1):
      KVM: PPC: Book3S HV: Protect updates to spapr_tce_tables list

 arch/powerpc/kvm/book3s_64_vio.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Radim Krčmář Sept. 8, 2017, 2:37 p.m. UTC | #1
2017-08-30 16:21+1000, Paul Mackerras:
> Paolo,
> 
> Please do a pull from my kvm-ppc-fixes branch to get one more commit
> for 4.13.  It adds mutual exclusion between list_add_rcu and
> list_del_rcu calls on the kvm->arch.spapr_tce_tables list.  Without
> this, userspace could potentially trigger corruption of the list and
> cause a host crash or worse.

Both Paolo and I had a vacation the week before final 4.13, so I merged
this for 3.14-rc1, sorry.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paolo Bonzini Sept. 9, 2017, 1:38 p.m. UTC | #2
On 08/09/2017 16:37, Radim Krčmář wrote:
> 2017-08-30 16:21+1000, Paul Mackerras:
>> Paolo,
>>
>> Please do a pull from my kvm-ppc-fixes branch to get one more commit
>> for 4.13.  It adds mutual exclusion between list_add_rcu and
>> list_del_rcu calls on the kvm->arch.spapr_tce_tables list.  Without
>> this, userspace could potentially trigger corruption of the list and
>> cause a host crash or worse.
> 
> Both Paolo and I had a vacation the week before final 4.13, so I merged
> this for 3.14-rc1, sorry.

Pi is always a nice source of typos.

I guess it needs to go in 4.13-stable too?  Paul, can you forward it to
stable@vger.kernel.org and include the "Fixes" information (which, by
the way, should probably be almost always included in -rc patches)?

Thanks,

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Mackerras Sept. 12, 2017, 4:01 a.m. UTC | #3
On Sat, Sep 09, 2017 at 03:38:31PM +0200, Paolo Bonzini wrote:
> On 08/09/2017 16:37, Radim Krčmář wrote:
> > 2017-08-30 16:21+1000, Paul Mackerras:
> >> Paolo,
> >>
> >> Please do a pull from my kvm-ppc-fixes branch to get one more commit
> >> for 4.13.  It adds mutual exclusion between list_add_rcu and
> >> list_del_rcu calls on the kvm->arch.spapr_tce_tables list.  Without
> >> this, userspace could potentially trigger corruption of the list and
> >> cause a host crash or worse.
> > 
> > Both Paolo and I had a vacation the week before final 4.13, so I merged
> > this for 3.14-rc1, sorry.
> 
> Pi is always a nice source of typos.

8-)

> I guess it needs to go in 4.13-stable too?  Paul, can you forward it to
> stable@vger.kernel.org and include the "Fixes" information (which, by
> the way, should probably be almost always included in -rc patches)?

Yes, I'll forward it and the previous patch in this area, with fixes
tags.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html