@@ -269,6 +269,8 @@ struct iavf_adapter {
u8 rxdid;
int num_active_queues;
int num_req_queues;
+ /* queue pairs sent so far, for ops that take more than one message */
+ int cfg_qps_sent;
/* TX */
struct iavf_ring *tx_rings;
@@ -1258,6 +1258,7 @@ static void iavf_configure(struct iavf_adapter *adapter)
iavf_configure_tx(adapter);
iavf_configure_rx(adapter);
+ adapter->cfg_qps_sent = 0;
adapter->aq_required |= IAVF_FLAG_AQ_CONFIGURE_QUEUES;
for (i = 0; i < adapter->num_active_queues; i++) {
@@ -8,6 +8,11 @@
#include "iavf_ptp.h"
#include "iavf_prototype.h"
+/* how many Flex Array Member entries do fit into VC message of type *ptr */
+#define iavf_max_vc_entries(ptr, flex_member) \
+ ((IAVF_MAX_AQ_BUF_SIZE - virtchnl_struct_size(ptr, flex_member, 1)) / \
+ sizeof(ptr->flex_member[0]) + 1)
+
/**
* iavf_send_pf_msg
* @adapter: adapter structure
@@ -375,11 +380,12 @@ int iavf_get_vf_ptp_caps(struct iavf_adapter *adapter)
void iavf_configure_queues(struct iavf_adapter *adapter)
{
struct virtchnl_vsi_queue_config_info *vqci;
- int pairs = adapter->num_active_queues;
struct virtchnl_queue_pair_info *vqpi;
+ int first = adapter->cfg_qps_sent;
u32 i, max_frame;
u8 rx_flags = 0;
size_t len;
+ int pairs;
max_frame = LIBIE_MAX_RX_FRM_LEN(adapter->rx_rings->pp->p.offset);
max_frame = min_not_zero(adapter->vf_res->max_mtu, max_frame);
@@ -391,6 +397,8 @@ void iavf_configure_queues(struct iavf_adapter *adapter)
return;
}
adapter->current_op = VIRTCHNL_OP_CONFIG_VSI_QUEUES;
+ pairs = min_t(int, adapter->num_active_queues - first,
+ iavf_max_vc_entries(vqci, qpair));
len = virtchnl_struct_size(vqci, qpair, pairs);
vqci = kzalloc(len, GFP_KERNEL);
if (!vqci)
@@ -402,10 +410,7 @@ void iavf_configure_queues(struct iavf_adapter *adapter)
vqci->vsi_id = adapter->vsi_res->vsi_id;
vqci->num_queue_pairs = pairs;
vqpi = vqci->qpair;
- /* Size check is not needed here - HW max is 16 queue pairs, and we
- * can fit info for 31 of them into the AQ buffer before it overflows.
- */
- for (i = 0; i < pairs; i++) {
+ for (i = first; i < first + pairs; i++) {
vqpi->txq.vsi_id = vqci->vsi_id;
vqpi->txq.queue_id = i;
vqpi->txq.ring_len = adapter->tx_rings[i].count;
@@ -425,7 +430,9 @@ void iavf_configure_queues(struct iavf_adapter *adapter)
vqpi++;
}
- adapter->aq_required &= ~IAVF_FLAG_AQ_CONFIGURE_QUEUES;
+ adapter->cfg_qps_sent += pairs;
+ if (adapter->cfg_qps_sent == adapter->num_active_queues)
+ adapter->aq_required &= ~IAVF_FLAG_AQ_CONFIGURE_QUEUES;
iavf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_VSI_QUEUES,
(u8 *)vqci, len);
kfree(vqci);
@@ -2551,6 +2558,12 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,
dev_warn(&adapter->pdev->dev, "Failed to Config Queue BW, error %s\n",
iavf_stat_str(&adapter->hw, v_retval));
break;
+ case VIRTCHNL_OP_CONFIG_VSI_QUEUES:
+ dev_err(&adapter->pdev->dev, "Failed to configure queues, error %s\n",
+ iavf_stat_str(&adapter->hw, v_retval));
+ /* don't send the remaining queue pairs */
+ adapter->aq_required &= ~IAVF_FLAG_AQ_CONFIGURE_QUEUES;
+ break;
default:
dev_err(&adapter->pdev->dev, "PF returned error %d (%s) to our request %d\n",
v_retval, iavf_stat_str(&adapter->hw, v_retval),
Extend iavf_configure_queues() to support more queue pairs than fit into a single virtchnl message (62). Virtchnl opcode used was already generic, but we have just not needed more than one message before. Send one message per call, and keep IAVF_FLAG_AQ_CONFIGURE_QUEUES set until all queue pairs are sent, similar to what iavf_add_ether_addrs() does for MAC filters. The next message goes out on a later watchdog run, once the reply to the previous one has cleared current_op, as for any other op. Stop sending on a PF NACK. Add helper, iavf_max_vc_entries(), that determines how many entries we could fit into virtchnl message (ending by flex array member). Will be also used on another op later in this series. Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> --- v4: * send one message per watchdog run, instead of polling for the reply to each one with a 1s timeout, which could resend the whole config after a late ACK or NACK, and could take a stale reply for the awaited one (Sashiko) * stop sending the rest on a PF NACK, in iavf_virtchnl_completion() v2: * fix typo (Sashiko) * abort iavf_configure_queues() at error (Sashiko) * report send and poll failures with dev_err(), they are not recoverable here (me) * cast via uintptr_t in iavf_match_vc_op_cb(), for clang W=1 -Wpointer-to-enum-cast * commit message: the limit is the number of queue pairs that fit into a single virtchnl message (62), not 31 * commit message: describe the switch to a synchronous op (Sashiko) * stop at PF NACK (Sashiko) * on timeout keep current_op and IAVF_FLAG_AQ_CONFIGURE_QUEUES set until the late reply arrives, instead of resending right away; clear both on other errors (no retry) (Sashiko) * fix dev_err() continuation alignment (Sashiko) --- drivers/net/ethernet/intel/iavf/iavf.h | 2 ++ drivers/net/ethernet/intel/iavf/iavf_main.c | 1 + .../net/ethernet/intel/iavf/iavf_virtchnl.c | 25 ++++++++++++++----- 3 files changed, 22 insertions(+), 6 deletions(-)