| Message ID | 20261024162405.133786-1-sashaneftin@gmail.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [iwl-next,v1] igc: remove redundant headers include from igc_tsn.c | expand |
> -----Original Message----- > From: Sasha Neftin <sashaneftin@gmail.com> > Sent: Saturday, October 24, 2026 6:24 PM > To: intel-wired-lan@osuosl.org > Subject: [iwl-next, v1] igc: remove redundant headers include from > igc_tsn.c > > igc.h already includes igc_hw.h and igc_hw.h already includes > igc_base.h, so the explicit include in igc_tsn.c is redundant. Drop it. > > Also, fix a minor typo in the #endif comment in igc_tsn.h. > > No functional change. > > Signed-off-by: Sasha Neftin <sashaneftin@gmail.com> > --- > drivers/net/ethernet/intel/igc/igc_tsn.c | 2 -- > drivers/net/ethernet/intel/igc/igc_tsn.h | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c > b/drivers/net/ethernet/intel/igc/igc_tsn.c > index d23a45a34fa3..868334e9e396 100644 > --- a/drivers/net/ethernet/intel/igc/igc_tsn.c > +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c > @@ -2,8 +2,6 @@ > /* Copyright (c) 2019 Intel Corporation */ > > #include "igc.h" > -#include "igc_base.h" > -#include "igc_hw.h" > #include "igc_tsn.h" > > #define MIN_MULTPLIER_TX_MIN_FRAG 0 > diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.h > b/drivers/net/ethernet/intel/igc/igc_tsn.h > index e08f48543d99..caca3720525e 100644 > --- a/drivers/net/ethernet/intel/igc/igc_tsn.h > +++ b/drivers/net/ethernet/intel/igc/igc_tsn.h > @@ -67,4 +67,4 @@ static inline bool igc_fpe_transmitted_smd_v(union > igc_adv_tx_desc *tx_desc) > return smd == SMD_V; > } > > -#endif /* _IGC_BASE_H */ > +#endif /* _IGC_TSN_H */ > -- > 2.53.0 Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c index d23a45a34fa3..868334e9e396 100644 --- a/drivers/net/ethernet/intel/igc/igc_tsn.c +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c @@ -2,8 +2,6 @@ /* Copyright (c) 2019 Intel Corporation */ #include "igc.h" -#include "igc_base.h" -#include "igc_hw.h" #include "igc_tsn.h" #define MIN_MULTPLIER_TX_MIN_FRAG 0 diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.h b/drivers/net/ethernet/intel/igc/igc_tsn.h index e08f48543d99..caca3720525e 100644 --- a/drivers/net/ethernet/intel/igc/igc_tsn.h +++ b/drivers/net/ethernet/intel/igc/igc_tsn.h @@ -67,4 +67,4 @@ static inline bool igc_fpe_transmitted_smd_v(union igc_adv_tx_desc *tx_desc) return smd == SMD_V; } -#endif /* _IGC_BASE_H */ +#endif /* _IGC_TSN_H */
igc.h already includes igc_hw.h and igc_hw.h already includes igc_base.h, so the explicit include in igc_tsn.c is redundant. Drop it. Also, fix a minor typo in the #endif comment in igc_tsn.h. No functional change. Signed-off-by: Sasha Neftin <sashaneftin@gmail.com> --- drivers/net/ethernet/intel/igc/igc_tsn.c | 2 -- drivers/net/ethernet/intel/igc/igc_tsn.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)