| Message ID | 20251107143051.2610996-1-alok.a.tiwari@oracle.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [net-next,v3] iavf: clarify VLAN add/delete log messages and lower log level | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Alok Tiwari > Sent: Friday, November 7, 2025 3:30 PM > To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Lobakin, > Aleksander <aleksander.lobakin@intel.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; andrew+netdev@lunn.ch; kuba@kernel.org; > davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; > horms@kernel.org; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org > Cc: alok.a.tiwarilinux@gmail.com; alok.a.tiwari@oracle.com > Subject: [Intel-wired-lan] [PATCH net-next v3] iavf: clarify VLAN > add/delete log messages and lower log level > > The current dev_warn messages for too many VLAN changes are confusing > and one place incorrectly references "add" instead of "delete" VLANs > due to copy-paste errors. > > - Use dev_info instead of dev_warn to lower the log level. > - Rephrase the message to: "virtchnl: Too many VLAN [add|delete] > ([v1|v2]) requests; splitting into multiple messages to PF\n". > > Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> > --- > v1 -> v2 > remove "\n" b/w message > added vvfl and vvfl_v2 prefix > v2 -> v3 > removed vvfl/vvfl_v2 prefix and using virtchnl: > prefix and (v1/v2) in the sentence suggested by Alex. > --- > drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > index 34a422a4a29c..88156082a41d 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c > @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter) > > len = virtchnl_struct_size(vvfl, vlan_id, count); > if (len > IAVF_MAX_AQ_BUF_SIZE) { > - dev_warn(&adapter->pdev->dev, "Too many add VLAN > changes in one request\n"); > + dev_info(&adapter->pdev->dev, > + "virtchnl: Too many VLAN add (v1) > requests; splitting into > +multiple messages to PF\n"); > while (len > IAVF_MAX_AQ_BUF_SIZE) > len = virtchnl_struct_size(vvfl, vlan_id, > --count); > @@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter) > > len = virtchnl_struct_size(vvfl_v2, filters, count); > if (len > IAVF_MAX_AQ_BUF_SIZE) { > - dev_warn(&adapter->pdev->dev, "Too many add VLAN > changes in one request\n"); > + dev_info(&adapter->pdev->dev, > + "virtchnl: Too many VLAN add (v2) > requests; splitting into > +multiple messages to PF\n"); > while (len > IAVF_MAX_AQ_BUF_SIZE) > len = virtchnl_struct_size(vvfl_v2, > filters, > --count); > @@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter) > > len = virtchnl_struct_size(vvfl, vlan_id, count); > if (len > IAVF_MAX_AQ_BUF_SIZE) { > - dev_warn(&adapter->pdev->dev, "Too many delete > VLAN changes in one request\n"); > + dev_info(&adapter->pdev->dev, > + "virtchnl: Too many VLAN delete (v1) > requests; splitting into > +multiple messages to PF\n"); > while (len > IAVF_MAX_AQ_BUF_SIZE) > len = virtchnl_struct_size(vvfl, vlan_id, > --count); > @@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter) > > len = virtchnl_struct_size(vvfl_v2, filters, count); > if (len > IAVF_MAX_AQ_BUF_SIZE) { > - dev_warn(&adapter->pdev->dev, "Too many add VLAN > changes in one request\n"); > + dev_info(&adapter->pdev->dev, > + "virtchnl: Too many VLAN delete (v2) > requests; splitting into > +multiple messages to PF\n"); > while (len > IAVF_MAX_AQ_BUF_SIZE) > len = virtchnl_struct_size(vvfl_v2, > filters, > --count); > -- > 2.50.1 I'd recommend try to use dev_info_ratelimited() to keeps operators informed but protects dmesg from bursts; But it's not a blocker. Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c index 34a422a4a29c..88156082a41d 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter) len = virtchnl_struct_size(vvfl, vlan_id, count); if (len > IAVF_MAX_AQ_BUF_SIZE) { - dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n"); + dev_info(&adapter->pdev->dev, + "virtchnl: Too many VLAN add (v1) requests; splitting into multiple messages to PF\n"); while (len > IAVF_MAX_AQ_BUF_SIZE) len = virtchnl_struct_size(vvfl, vlan_id, --count); @@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter) len = virtchnl_struct_size(vvfl_v2, filters, count); if (len > IAVF_MAX_AQ_BUF_SIZE) { - dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n"); + dev_info(&adapter->pdev->dev, + "virtchnl: Too many VLAN add (v2) requests; splitting into multiple messages to PF\n"); while (len > IAVF_MAX_AQ_BUF_SIZE) len = virtchnl_struct_size(vvfl_v2, filters, --count); @@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter) len = virtchnl_struct_size(vvfl, vlan_id, count); if (len > IAVF_MAX_AQ_BUF_SIZE) { - dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n"); + dev_info(&adapter->pdev->dev, + "virtchnl: Too many VLAN delete (v1) requests; splitting into multiple messages to PF\n"); while (len > IAVF_MAX_AQ_BUF_SIZE) len = virtchnl_struct_size(vvfl, vlan_id, --count); @@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter) len = virtchnl_struct_size(vvfl_v2, filters, count); if (len > IAVF_MAX_AQ_BUF_SIZE) { - dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n"); + dev_info(&adapter->pdev->dev, + "virtchnl: Too many VLAN delete (v2) requests; splitting into multiple messages to PF\n"); while (len > IAVF_MAX_AQ_BUF_SIZE) len = virtchnl_struct_size(vvfl_v2, filters, --count);