| Message ID | 20251021193203.2393365-1-alok.a.tiwari@oracle.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [net-next] igbvf: fix misplaced newline in VLAN add warning message | expand |
On Tue, Oct 21, 2025 at 12:32:01PM -0700, Alok Tiwari wrote: > Corrected the dev_warn format string: > - "Vlan id %d\n is not added" -> "Vlan id %d is not added\n" > > Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Interesting, there seem to be some other cases of this, at least under net/divers. Do you plan to address those too? In any case, looks good to me. Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 61dfcd8cb370..ac57212ab02b 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -1235,7 +1235,7 @@ static int igbvf_vlan_rx_add_vid(struct net_device *netdev, spin_lock_bh(&hw->mbx_lock); if (hw->mac.ops.set_vfta(hw, vid, true)) { - dev_warn(&adapter->pdev->dev, "Vlan id %d\n is not added", vid); + dev_warn(&adapter->pdev->dev, "Vlan id %d is not added\n", vid); spin_unlock_bh(&hw->mbx_lock); return -EINVAL; }
Corrected the dev_warn format string: - "Vlan id %d\n is not added" -> "Vlan id %d is not added\n" Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> --- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)