| Message ID | 20251006123741.43462-3-enjuk@amazon.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | igb/igc/ixgbe: use EOPNOTSUPP instead of ENOTSUPP | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Kohei Enju > Sent: Monday, October 6, 2025 2:35 PM > To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org > Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn > <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric > Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo > Abeni <pabeni@redhat.com>; Auke Kok <auke-jan.h.kok@intel.com>; Jeff > Garzik <jgarzik@redhat.com>; Sasha Neftin <sasha.neftin@intel.com>; > Richard Cochran <richardcochran@gmail.com>; Keller, Jacob E > <jacob.e.keller@intel.com>; kohei.enju@gmail.com; Kohei Enju > <enjuk@amazon.com> > Subject: [Intel-wired-lan] [PATCH iwl-net v1 2/3] igc: use EOPNOTSUPP > instead of ENOTSUPP in igc_ethtool_get_sset_count() > > igc_ethtool_get_sset_count() returns -ENOTSUPP when a given stringset > is not supported, causing userland programs to get "Unknown error > 524". > > Since EOPNOTSUPP should be used when error is propagated to userland, > return -EOPNOTSUPP instead of -ENOTSUPP. > > Fixes: 36b9fea60961 ("igc: Add support for statistics") > Signed-off-by: Kohei Enju <enjuk@amazon.com> > --- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c > b/drivers/net/ethernet/intel/igc/igc_ethtool.c > index ca93629b1d3a..bb783042d1af 100644 > --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c > +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c > @@ -810,7 +810,7 @@ static int igc_ethtool_get_sset_count(struct > net_device *netdev, int sset) > case ETH_SS_PRIV_FLAGS: > return IGC_PRIV_FLAGS_STR_LEN; > default: > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > } > > -- > 2.48.1 Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c index ca93629b1d3a..bb783042d1af 100644 --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c @@ -810,7 +810,7 @@ static int igc_ethtool_get_sset_count(struct net_device *netdev, int sset) case ETH_SS_PRIV_FLAGS: return IGC_PRIV_FLAGS_STR_LEN; default: - return -ENOTSUPP; + return -EOPNOTSUPP; } }
igc_ethtool_get_sset_count() returns -ENOTSUPP when a given stringset is not supported, causing userland programs to get "Unknown error 524". Since EOPNOTSUPP should be used when error is propagated to userland, return -EOPNOTSUPP instead of -ENOTSUPP. Fixes: 36b9fea60961 ("igc: Add support for statistics") Signed-off-by: Kohei Enju <enjuk@amazon.com> --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)