diff mbox series

[linux-next] net: e100: Use str_read_write() helper

Message ID 20250515204414844_YQsk90Odo5a3bx9qvo8g@zte.com.cn
State Rejected
Headers show
Series [linux-next] net: e100: Use str_read_write() helper | expand

Commit Message

long.yunjian@zte.com.cn May 15, 2025, 12:44 p.m. UTC 
From: Yumeng Fang <fang.yumeng@zte.com.cn>

Remove hard-coded strings by using the str_read_write() helper.

Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn>
---
 drivers/net/ethernet/intel/e100.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index c0ead54ea186..ab93caab72bb 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -147,6 +147,7 @@ 
 #include <linux/firmware.h>
 #include <linux/rtnetlink.h>
 #include <linux/unaligned.h>
+#include <linux/string_choices.h>


 #define DRV_NAME		"e100"
@@ -946,7 +947,7 @@  static u16 mdio_ctrl_hw(struct nic *nic, u32 addr, u32 dir, u32 reg, u16 data)
 	spin_unlock_irqrestore(&nic->mdio_lock, flags);
 	netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
 		     "%s:addr=%d, reg=%d, data_in=0x%04X, data_out=0x%04X\n",
-		     dir == mdi_read ? "READ" : "WRITE",
+		     str_read_write(dir == mdi_read),
 		     addr, reg, data, data_out);
 	return (u16)data_out;
 }
@@ -1009,7 +1010,7 @@  static u16 mdio_ctrl_phy_mii_emulated(struct nic *nic,
 		default:
 			netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
 				     "%s:addr=%d, reg=%d, data=0x%04X: unimplemented emulation!\n",
-				     dir == mdi_read ? "READ" : "WRITE",
+				     str_read_write(dir == mdi_read),
 				     addr, reg, data);
 			return 0xFFFF;
 		}
@@ -1018,7 +1019,7 @@  static u16 mdio_ctrl_phy_mii_emulated(struct nic *nic,
 		default:
 			netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
 				     "%s:addr=%d, reg=%d, data=0x%04X: unimplemented emulation!\n",
-				     dir == mdi_read ? "READ" : "WRITE",
+				     str_read_write(dir == mdi_read),
 				     addr, reg, data);
 			return 0xFFFF;
 		}