From patchwork Tue Apr 16 14:43:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= X-Patchwork-Id: 1924244 X-Patchwork-Delegate: anthony.l.nguyen@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=m0KVTZo0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJnB53v1Pz1yZC for ; Wed, 17 Apr 2024 00:54:21 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7D386402DB; Tue, 16 Apr 2024 14:54:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ENlaNIcr2_PX; Tue, 16 Apr 2024 14:54:17 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BEDA7402BF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713279257; bh=Cdex+RLb2jzqXfAekeGWlDlcKGNNQhFdd260BFjkXVo=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=m0KVTZo013xhVsj5hbDeGS/ST3Lz15lobP4nmZeTUM66T5aZhfpa2jYv+bfzOgnAG 6uAUqeTMpFtgURsjH3CZJSMR2cfyvFydEs15ny2cLaFyopWjlqLUZi0f8d+cH5vAIP 9B+pL4jDK6QJvG8dpZjRTXKPBkE9LXS86Qya4GPwjVGHatHWKyNefaF/IHgWnSqZV2 0RN8OskBLpskOs1imAs6lKLJqtokb8o1LXhtpBnsVPXwavRUXTk22P34oUtp//HaJw rAlcpcETFI6BHGMUQPDnUjvjB34HC6bonrGkq4DrYFTNpYOXaZWrrJd/IzlUFRGRt1 5U/sgv6QBiaEA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id BEDA7402BF; Tue, 16 Apr 2024 14:54:17 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id BC3C41BF977 for ; Tue, 16 Apr 2024 14:54:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A8B0240BA7 for ; Tue, 16 Apr 2024 14:54:15 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 33MlHPQ2n7ex for ; Tue, 16 Apr 2024 14:54:15 +0000 (UTC) X-Greylist: delayed 602 seconds by postgrey-1.37 at util1.osuosl.org; Tue, 16 Apr 2024 14:54:13 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 9F25640383 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9F25640383 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.104.135.124; helo=mail1.fiberby.net; envelope-from=ast@fiberby.net; receiver= Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 9F25640383 for ; Tue, 16 Apr 2024 14:54:13 +0000 (UTC) Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 71B41600A2; Tue, 16 Apr 2024 14:43:50 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id B5812202498; Tue, 16 Apr 2024 14:43:20 +0000 (UTC) From: =?utf-8?q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= To: intel-wired-lan@lists.osuosl.org Date: Tue, 16 Apr 2024 14:43:19 +0000 Message-ID: <20240416144320.15300-1-ast@fiberby.net> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1713278649; bh=1ISri2bYvVsZAxWaG9HkNxGsuBog0gqAtEuAMx45XWs=; h=From:To:Cc:Subject:Date:From; b=cJ77AM88UOdtiL1hxDlCM/LDyadeS5Fy4mTUBJZ0bVwdC0BAa5qi/0Tepp86grPka VTRhnsMsOkx71RdasvKCZM4gyoNMJVcquFGND2lIX1sECz9YsgAxq91W+LNFDN7jpV T8PrgAtr0OEqOhdfxLDOVS5hd4dMAcvazMFESrpKpxN9JOU55v1weh310C/1bB1fGh dLhaIXut+mYSpUmSMiZsEoJOFkDKuBDItY4UR/dLgNZXa6SvS7G/2bXSAK/Kw/bQIx kCg5VHbl7GxQmUjkw0Vnq/EtO/5bV+eYWh8ubbCNjv5hIkJekGPac9stRnzO6F9wnu p5u0BFCA7Ztpg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=fiberby.net header.i=@fiberby.net header.a=rsa-sha256 header.s=202008 header.b=cJ77AM88 Subject: [Intel-wired-lan] [PATCH iwl-next] i40e: flower: validate control flags X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , =?utf-8?q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= , Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This driver currently doesn't support any control flags. Use flow_rule_has_control_flags() to check for control flags, such as can be set through `tc flower ... ip_flags frag`. In case any control flags are masked, flow_rule_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP. Only compile-tested. Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Simon Horman Tested-by: Sujai Buvaneswaran --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 0bdcdea0be3e..e219f757820d 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -8643,6 +8643,10 @@ static int i40e_parse_cls_flower(struct i40e_vsi *vsi, flow_rule_match_control(rule, &match); addr_type = match.key->addr_type; + + if (flow_rule_has_control_flags(match.mask->flags, + f->common.extack)) + return -EOPNOTSUPP; } if (addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {