diff mbox series

[iwl-next,1/2] iavf: drop duplicate iavf_{add|del}_cloud_filter() calls

Message ID 20240226132103.69122-1-aleksei.kodanev@bell-sw.com
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series [iwl-next,1/2] iavf: drop duplicate iavf_{add|del}_cloud_filter() calls | expand

Commit Message

Alexey Kodanev Feb. 26, 2024, 1:21 p.m. UTC 
There are currently two pairs of identical checks and calls
to iavf_{add|del}_cloud_filter().

Detected using the static analysis tool - Svace.

Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Ahmed Zaki Feb. 26, 2024, 10:30 p.m. UTC | #1 
On 2024-02-26 6:21 a.m., Alexey Kodanev wrote:
> There are currently two pairs of identical checks and calls
> to iavf_{add|del}_cloud_filter().
> 
> Detected using the static analysis tool - Svace.
> 
> Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
> ---
>   drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 335fd13e86f7..5097efa2e1cd 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -2170,19 +2170,10 @@ static int iavf_process_aq_command(struct iavf_adapter *adapter)
>   		iavf_add_cloud_filter(adapter);
>   		return 0;
>   	}
> -
> -	if (adapter->aq_required & IAVF_FLAG_AQ_DEL_CLOUD_FILTER) {
> -		iavf_del_cloud_filter(adapter);
> -		return 0;
> -	}
>   	if (adapter->aq_required & IAVF_FLAG_AQ_DEL_CLOUD_FILTER) {
>   		iavf_del_cloud_filter(adapter);
>   		return 0;
>   	}
> -	if (adapter->aq_required & IAVF_FLAG_AQ_ADD_CLOUD_FILTER) {
> -		iavf_add_cloud_filter(adapter);
> -		return 0;
> -	}
>   	if (adapter->aq_required & IAVF_FLAG_AQ_ADD_FDIR_FILTER) {
>   		iavf_add_fdir_filter(adapter);
>   		return IAVF_SUCCESS;

Thanks.

Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 335fd13e86f7..5097efa2e1cd 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2170,19 +2170,10 @@  static int iavf_process_aq_command(struct iavf_adapter *adapter)
 		iavf_add_cloud_filter(adapter);
 		return 0;
 	}
-
-	if (adapter->aq_required & IAVF_FLAG_AQ_DEL_CLOUD_FILTER) {
-		iavf_del_cloud_filter(adapter);
-		return 0;
-	}
 	if (adapter->aq_required & IAVF_FLAG_AQ_DEL_CLOUD_FILTER) {
 		iavf_del_cloud_filter(adapter);
 		return 0;
 	}
-	if (adapter->aq_required & IAVF_FLAG_AQ_ADD_CLOUD_FILTER) {
-		iavf_add_cloud_filter(adapter);
-		return 0;
-	}
 	if (adapter->aq_required & IAVF_FLAG_AQ_ADD_FDIR_FILTER) {
 		iavf_add_fdir_filter(adapter);
 		return IAVF_SUCCESS;