| Message ID | 20231120112726.149409-1-jan.sokolowski@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [iwl-next,v1] ice: remove rx_len_errors statistic | expand |
On 11/20/2023 3:27 AM, Jan Sokolowski wrote: > It was found that this statistic is incorrectly reported > by HW and thus, useless. > > Remove it. Is there any further information about what is reported incorrectly? Is rx_length_errors part of netdev stats and standardized? Does HW fail to report some packets or does it report packets which don't have an issue? I mean the hardware does *something*, so I think it would be good to have an understanding of how this differs from what we expected when proposing to remove it. Thanks, Jake
> >On 11/20/2023 3:27 AM, Jan Sokolowski wrote: >> It was found that this statistic is incorrectly reported >> by HW and thus, useless. >> >> Remove it. > >Is there any further information about what is reported incorrectly? Is >rx_length_errors part of netdev stats and standardized? Does HW fail to >report some packets or does it report packets which don't have an issue? > It's a part of visible stats, standardized. According to the bug report, HW was misreporting packets that did not have any issues. >I mean the hardware does *something*, so I think it would be good to >have an understanding of how this differs from what we expected when >proposing to remove it. > >Thanks, >Jake >_______________________________________________ >Intel-wired-lan mailing list >Intel-wired-lan@osuosl.org >https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
On 11/29/23 11:26, Sokolowski, Jan wrote: >> >> On 11/20/2023 3:27 AM, Jan Sokolowski wrote: >>> It was found that this statistic is incorrectly reported >>> by HW and thus, useless. >>> >>> Remove it. >> >> Is there any further information about what is reported incorrectly? Is >> rx_length_errors part of netdev stats and standardized? Does HW fail to >> report some packets or does it report packets which don't have an issue? Great questions >> > > It's a part of visible stats, standardized. Please add that info into commit message of v2, and CC netdev. Perhaps one could ask if it would be better to always-report-zero as a value of that, standardized, stat. But if we could just remove it, it's better. > > According to the bug report, HW was misreporting packets that did not have any issues. > >> I mean the hardware does *something*, so I think it would be good to >> have an understanding of how this differs from what we expected when >> proposing to remove it. >> >> Thanks, >> Jake >> _______________________________________________ >> Intel-wired-lan mailing list >> Intel-wired-lan@osuosl.org >> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c index a34083567e6f..cda98e185254 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -129,7 +129,6 @@ static const struct ice_stats ice_gstrings_pf_stats[] = { ICE_PF_STAT("rx_oversize.nic", stats.rx_oversize), ICE_PF_STAT("rx_jabber.nic", stats.rx_jabber), ICE_PF_STAT("rx_csum_bad.nic", hw_csum_rx_error), - ICE_PF_STAT("rx_length_errors.nic", stats.rx_len_errors), ICE_PF_STAT("rx_dropped.nic", stats.eth.rx_discards), ICE_PF_STAT("rx_crc_errors.nic", stats.crc_errors), ICE_PF_STAT("illegal_bytes.nic", stats.illegal_bytes), diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 81044cc10931..ddeb43059126 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -6732,13 +6732,11 @@ void ice_update_vsi_stats(struct ice_vsi *vsi) cur_ns->rx_crc_errors = pf->stats.crc_errors; cur_ns->rx_errors = pf->stats.crc_errors + pf->stats.illegal_bytes + - pf->stats.rx_len_errors + pf->stats.rx_undersize + pf->hw_csum_rx_error + pf->stats.rx_jabber + pf->stats.rx_fragments + pf->stats.rx_oversize; - cur_ns->rx_length_errors = pf->stats.rx_len_errors; /* record drops from the port level */ cur_ns->rx_missed_errors = pf->stats.eth.rx_discards; } @@ -6878,9 +6876,6 @@ void ice_update_pf_stats(struct ice_pf *pf) &prev_ps->mac_remote_faults, &cur_ps->mac_remote_faults); - ice_stat_update32(hw, GLPRT_RLEC(port), pf->stat_prev_loaded, - &prev_ps->rx_len_errors, &cur_ps->rx_len_errors); - ice_stat_update32(hw, GLPRT_RUC(port), pf->stat_prev_loaded, &prev_ps->rx_undersize, &cur_ps->rx_undersize); diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h index 16615e322382..306d0141ea8e 100644 --- a/drivers/net/ethernet/intel/ice/ice_type.h +++ b/drivers/net/ethernet/intel/ice/ice_type.h @@ -1001,7 +1001,6 @@ struct ice_hw_port_stats { u64 error_bytes; /* errbc */ u64 mac_local_faults; /* mlfc */ u64 mac_remote_faults; /* mrfc */ - u64 rx_len_errors; /* rlec */ u64 link_xon_rx; /* lxonrxc */ u64 link_xoff_rx; /* lxoffrxc */ u64 link_xon_tx; /* lxontxc */
It was found that this statistic is incorrectly reported by HW and thus, useless. Remove it. Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com> --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 - drivers/net/ethernet/intel/ice/ice_main.c | 5 ----- drivers/net/ethernet/intel/ice/ice_type.h | 1 - 3 files changed, 7 deletions(-)