| Message ID | 20230912102312.232945-1-kamil.maziarz@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [iwl-net,v1] ice: don't stop netdev tx queues when setting up XSK socket | expand |
>-----Original Message----- >From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of >Maziarz, Kamil >Sent: Tuesday, September 12, 2023 3:53 PM >To: intel-wired-lan@lists.osuosl.org >Cc: Maziarz, Kamil <kamil.maziarz@intel.com> >Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: don't stop netdev tx queues >when setting up XSK socket > >Avoid stopping netdev tx queues during XSK setup by removing >netif_tx_stop_queue() and netif_tx_start_queue(). >These changes prevent unnecessary stopping and starting of netdev transmit >queues during the setup of XDP socket. Without this change, after stopping the >XDP traffic flow tracker and then stopping the XDP prog - NETDEV WATCHDOG >transmit queue timed out appears. > >Fixes: 2d4238f55697 ("ice: Add support for AF_XDP") >Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com> >--- > drivers/net/ethernet/intel/ice/ice_xsk.c | 2 -- > 1 file changed, 2 deletions(-) > Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c index a7fe2b4ce655..cd56ceae8aef 100644 --- a/drivers/net/ethernet/intel/ice/ice_xsk.c +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c @@ -179,7 +179,6 @@ static int ice_qp_dis(struct ice_vsi *vsi, u16 q_idx) return -EBUSY; usleep_range(1000, 2000); } - netif_tx_stop_queue(netdev_get_tx_queue(vsi->netdev, q_idx)); ice_fill_txq_meta(vsi, tx_ring, &txq_meta); err = ice_vsi_stop_tx_ring(vsi, ICE_NO_RESET, 0, tx_ring, &txq_meta); @@ -268,7 +267,6 @@ static int ice_qp_ena(struct ice_vsi *vsi, u16 q_idx) ice_qvec_toggle_napi(vsi, q_vector, true); ice_qvec_ena_irq(vsi, q_vector); - netif_tx_start_queue(netdev_get_tx_queue(vsi->netdev, q_idx)); free_buf: kfree(qg_buf); return err;
Avoid stopping netdev tx queues during XSK setup by removing netif_tx_stop_queue() and netif_tx_start_queue(). These changes prevent unnecessary stopping and starting of netdev transmit queues during the setup of XDP socket. Without this change, after stopping the XDP traffic flow tracker and then stopping the XDP prog - NETDEV WATCHDOG transmit queue timed out appears. Fixes: 2d4238f55697 ("ice: Add support for AF_XDP") Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com> --- drivers/net/ethernet/intel/ice/ice_xsk.c | 2 -- 1 file changed, 2 deletions(-)