| Message ID | 20230516035113.4147-1-muhammad.husaini.zulkifli@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [iwl-net,v1] igc: Remove delay during TX ring configuration | expand |
On 5/16/2023 06:51, Muhammad Husaini Zulkifli wrote: > Remove unnecessary delay during the TX ring configuration. > It doesn't mentioned about this delay in the Software User Manual. > It might have been ported from legacy code I210 in the past. > > Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings") > Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index ca0e6d4141a05..b1d0b3a8bdc41 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter *adapter, > /* disable the queue */ > wr32(IGC_TXDCTL(reg_idx), 0); > wrfl(); > - mdelay(10); > > wr32(IGC_TDLEN(reg_idx), > ring->count * sizeof(union igc_adv_tx_desc)); Acked-by: Sasha Neftin <sasha.neftin@intel.com>
On 5/15/2023 8:51 PM, Muhammad Husaini Zulkifli wrote: > Remove unnecessary delay during the TX ring configuration. > It doesn't mentioned about this delay in the Software User Manual. > It might have been ported from legacy code I210 in the past. Can you please provide more info. What's the problem you're fixing? How is this fixing it? If there's a splat, that would be helpful. > Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings") > Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index ca0e6d4141a05..b1d0b3a8bdc41 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter *adapter, > /* disable the queue */ > wr32(IGC_TXDCTL(reg_idx), 0); > wrfl(); > - mdelay(10); > > wr32(IGC_TDLEN(reg_idx), > ring->count * sizeof(union igc_adv_tx_desc));
Hi Tony, > On 5/15/2023 8:51 PM, Muhammad Husaini Zulkifli wrote: > > Remove unnecessary delay during the TX ring configuration. > > It doesn't mentioned about this delay in the Software User Manual. > > It might have been ported from legacy code I210 in the past. > > Can you please provide more info. What's the problem you're fixing? How is > this fixing it? If there's a splat, that would be helpful. There is no splat for this. This will cause more delay ex. link up activity especially during reset adapter task. I do not see any need for this as it does not mentioned in software manual. Plus, during TSN mode GCL scheduling configuration, we want to remove the delay of this 10ms for real time activity as well. I got pinged Sasha previously and we agreed to remove this delay. > > > Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings") > > Signed-off-by: Muhammad Husaini Zulkifli > > <muhammad.husaini.zulkifli@intel.com> > > --- > > drivers/net/ethernet/intel/igc/igc_main.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c > > b/drivers/net/ethernet/intel/igc/igc_main.c > > index ca0e6d4141a05..b1d0b3a8bdc41 100644 > > --- a/drivers/net/ethernet/intel/igc/igc_main.c > > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > > @@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter > *adapter, > > /* disable the queue */ > > wr32(IGC_TXDCTL(reg_idx), 0); > > wrfl(); > > - mdelay(10); > > > > wr32(IGC_TDLEN(reg_idx), > > ring->count * sizeof(union igc_adv_tx_desc));
On 5/16/2023 3:47 PM, Zulkifli, Muhammad Husaini wrote: > Hi Tony, > >> On 5/15/2023 8:51 PM, Muhammad Husaini Zulkifli wrote: >>> Remove unnecessary delay during the TX ring configuration. >>> It doesn't mentioned about this delay in the Software User Manual. >>> It might have been ported from legacy code I210 in the past. >> >> Can you please provide more info. What's the problem you're fixing? How is >> this fixing it? If there's a splat, that would be helpful. > > There is no splat for this. This will cause more delay ex. link up activity > especially during reset adapter task. I do not see any need for this as it does not > mentioned in software manual. Plus, during TSN mode GCL scheduling configuration, > we want to remove the delay of this 10ms for real time activity as well. > I got pinged Sasha previously and we agreed to remove this delay. Can you please update the commit message with applicable information that you mentioned here. This commit message doesn't give enough information about the problem or the solution. Description tips[1]. >> >>> Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings") >>> Signed-off-by: Muhammad Husaini Zulkifli >>> <muhammad.husaini.zulkifli@intel.com> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> On 5/16/2023 3:47 PM, Zulkifli, Muhammad Husaini wrote: > > Hi Tony, > > > >> On 5/15/2023 8:51 PM, Muhammad Husaini Zulkifli wrote: > >>> Remove unnecessary delay during the TX ring configuration. > >>> It doesn't mentioned about this delay in the Software User Manual. > >>> It might have been ported from legacy code I210 in the past. > >> > >> Can you please provide more info. What's the problem you're fixing? > >> How is this fixing it? If there's a splat, that would be helpful. > > > > There is no splat for this. This will cause more delay ex. link up > > activity especially during reset adapter task. I do not see any need > > for this as it does not mentioned in software manual. Plus, during TSN > > mode GCL scheduling configuration, we want to remove the delay of this > 10ms for real time activity as well. > > I got pinged Sasha previously and we agreed to remove this delay. > > Can you please update the commit message with applicable information that > you mentioned here. This commit message doesn't give enough information > about the problem or the solution. Description tips[1]. Sure. Will push again. > > >> > >>> Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings") > >>> Signed-off-by: Muhammad Husaini Zulkifli > >>> <muhammad.husaini.zulkifli@intel.com> > > [1] > https://www.kernel.org/doc/html/latest/process/submitting- > patches.html#describe-your-changes
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index ca0e6d4141a05..b1d0b3a8bdc41 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter *adapter, /* disable the queue */ wr32(IGC_TXDCTL(reg_idx), 0); wrfl(); - mdelay(10); wr32(IGC_TDLEN(reg_idx), ring->count * sizeof(union igc_adv_tx_desc));
Remove unnecessary delay during the TX ring configuration. It doesn't mentioned about this delay in the Software User Manual. It might have been ported from legacy code I210 in the past. Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings") Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> --- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-)