| Message ID | 20230201145845.2312060-7-o.rempel@pengutronix.de |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | net: add EEE support for KSZ9477 and AR8035 with i.MX6 | expand |
> + /* This is optional functionality. If not supported, we may get an error > + * which should be ignored. > + */ > + genphy_c45_read_eee_abilities(phydev); Humm, philosophic discussion. Would it be better for genphy_c45_read_eee_abilities() to silently ignore the error? Errors like -ETIMEDOUT should probably be returned, but -EOPNOTSUPP should be ignored. Andrew
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 3651f1fd8fc9..0c47fa765b69 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed) { int err; - if (genphy_config_eee_advert(phydev)) + err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (err < 0) + return err; + else if (err) changed = true; err = genphy_setup_master_slave(phydev); @@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev) phydev->supported, val & ESTATUS_1000_XFULL); } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL(genphy_read_abilities);
Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/phy_device.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)