| Message ID | 20221221113822.12858-8-michal.swiatkowski@linux.intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | implement devlink reload in ice | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Michal Swiatkowski > Sent: Wednesday, December 21, 2022 5:08 PM > To: intel-wired-lan@lists.osuosl.org > Cc: Ismail, Mustafa <mustafa.ismail@intel.com>; Mikailenko, Benjamin > <benjamin.mikailenko@intel.com>; Brandeburg, Jesse > <jesse.brandeburg@intel.com>; Kaliszczuk, Leszek > <leszek.kaliszczuk@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kitszel@intel.com>; Saleem, Shiraz <shiraz.saleem@intel.com> > Subject: [Intel-wired-lan] [PATCH net-next v3 07/10] ice: sync netdev filters > after clearing VSI > > In driver reload path the netdev isn't removed, but VSI is. Remove filters on > netdev right after removing them on VSI. > > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > --- > drivers/net/ethernet/intel/ice/ice_fltr.c | 5 +++++ > 1 file changed, 5 insertions(+) > Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
diff --git a/drivers/net/ethernet/intel/ice/ice_fltr.c b/drivers/net/ethernet/intel/ice/ice_fltr.c index 40e678cfb507..aff7a141c30d 100644 --- a/drivers/net/ethernet/intel/ice/ice_fltr.c +++ b/drivers/net/ethernet/intel/ice/ice_fltr.c @@ -208,6 +208,11 @@ static int ice_fltr_remove_eth_list(struct ice_vsi *vsi, struct list_head *list) void ice_fltr_remove_all(struct ice_vsi *vsi) { ice_remove_vsi_fltr(&vsi->back->hw, vsi->idx); + /* sync netdev filters if exist */ + if (vsi->netdev) { + __dev_uc_unsync(vsi->netdev, NULL); + __dev_mc_unsync(vsi->netdev, NULL); + } } /**
In driver reload path the netdev isn't removed, but VSI is. Remove filters on netdev right after removing them on VSI. Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> --- drivers/net/ethernet/intel/ice/ice_fltr.c | 5 +++++ 1 file changed, 5 insertions(+)