Message ID | 20221201115859.1175650-1-kalyan.kodamagula@intel.com |
---|---|
State | Accepted |
Delegated to: | Anthony Nguyen |
Headers | show |
Series | [net-next,v4] ice: Add more usage of existing function ice_get_vf_vsi(vf) | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Kalyan Kodamagula > Sent: Thursday, December 1, 2022 12:59 PM > To: intel-wired-lan@lists.osuosl.org > Cc: Brett Creeley <brett.creeley@intel.com> > Subject: [Intel-wired-lan] [PATCH net-next v4] ice: Add more usage of > existing function ice_get_vf_vsi(vf) > > From: Brett Creeley <brett.creeley@intel.com> > > Extend the usage of function ice_get_vf_vsi(vf) in multiple places instead of > VF's VSI by using a long string of dereferences (i.e. vf->pf->vsi[vf- > >lan_vsi_idx]). > > Signed-off-by: Brett Creeley <brett.creeley@intel.com> > Signed-off-by: Kalyan Kodamagula <kalyan.kodamagula@intel.com> > > --- > V3->V4: Added change log. > V2->V3: Removed Fixes: tag, Since change is refactor and not a bug fix. > V1->V2: Renaming from net to net-next in header, as this is not a fix. > --- > drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c > b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c > index c6a58343d81d..e6ef6b303222 100644 > --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c > +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c Tested-by: Piotr Tyda <piotr.tyda@intel.com>
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c index c6a58343d81d..e6ef6b303222 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c @@ -113,7 +113,7 @@ ice_vc_fdir_param_check(struct ice_vf *vf, u16 vsi_id) if (!ice_vc_isvalid_vsi_id(vf, vsi_id)) return -EINVAL; - if (!pf->vsi[vf->lan_vsi_idx]) + if (!ice_get_vf_vsi(vf)) return -EINVAL; return 0; @@ -494,7 +494,7 @@ ice_vc_fdir_rem_prof(struct ice_vf *vf, enum ice_fltr_ptype flow, int tun) vf_prof = fdir->fdir_prof[flow]; - vf_vsi = pf->vsi[vf->lan_vsi_idx]; + vf_vsi = ice_get_vf_vsi(vf); if (!vf_vsi) { dev_dbg(dev, "NULL vf %d vsi pointer\n", vf->vf_id); return; @@ -572,7 +572,7 @@ ice_vc_fdir_write_flow_prof(struct ice_vf *vf, enum ice_fltr_ptype flow, pf = vf->pf; dev = ice_pf_to_dev(pf); hw = &pf->hw; - vf_vsi = pf->vsi[vf->lan_vsi_idx]; + vf_vsi = ice_get_vf_vsi(vf); if (!vf_vsi) return -EINVAL; @@ -1205,7 +1205,7 @@ static int ice_vc_fdir_write_fltr(struct ice_vf *vf, pf = vf->pf; dev = ice_pf_to_dev(pf); hw = &pf->hw; - vsi = pf->vsi[vf->lan_vsi_idx]; + vsi = ice_get_vf_vsi(vf); if (!vsi) { dev_dbg(dev, "Invalid vsi for VF %d\n", vf->vf_id); return -EINVAL;