Message ID | 20221003082615.1870-1-jan.sokolowski@intel.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [net-next,v1] ixgbevf: Add error messages on vlan error | expand |
Dear Jan, Thank you for your patch. Two nits. Am 03.10.22 um 10:26 schrieb Jan Sokolowski: > From: "Sokolowski, Jan" <jan.sokolowski@intel.com> Please adapt your git configuration to use Jan Sokolowski <jan.sokolowski@intel.com> > ixgbevf did not provide an error in dmesg if VLAN > addition failed. This fits in one. line. > Add more descriptive failure messages in the kernel log. *more descriptive* is ambiguous, maybe just: Add two descriptive …? […] Kind regards, Paul
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 2f12fbe229c1..f1e5809f4d22 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -2044,12 +2044,16 @@ static int ixgbevf_vlan_rx_add_vid(struct net_device *netdev, spin_unlock_bh(&adapter->mbx_lock); - /* translate error return types so error makes sense */ - if (err == IXGBE_ERR_MBX) - return -EIO; + if (err) { + netdev_err(netdev, "VF could not set VLAN %d\n", vid); + + /* translate error return types so error makes sense */ + if (err == IXGBE_ERR_MBX) + return -EIO; - if (err == IXGBE_ERR_INVALID_ARGUMENT) - return -EACCES; + if (err == IXGBE_ERR_INVALID_ARGUMENT) + return -EACCES; + } set_bit(vid, adapter->active_vlans); @@ -2070,6 +2074,9 @@ static int ixgbevf_vlan_rx_kill_vid(struct net_device *netdev, spin_unlock_bh(&adapter->mbx_lock); + if (err) + netdev_err(netdev, "Could not remove VLAN %d\n", vid); + clear_bit(vid, adapter->active_vlans); return err;