diff mbox series

[net,v1] iavf: Fix missing state logs

Message ID 20220607235328.3430866-1-xuejun.zhang@intel.com
State Superseded
Headers show
Series [net,v1] iavf: Fix missing state logs | expand

Commit Message

Zhang, Xuejun June 7, 2022, 11:53 p.m. UTC
Fix debug prints, by adding missing state prints.
Extend iavf_state_str by strings for __IAVF_INIT_EXTENDED_CAPS and
__IAVF_INIT_CONFIG_ADAPTER.
Without this patch, when enabling debug prints for iavf.h, user will
see:
iavf 0000:06:0e.0: state transition from:__IAVF_INIT_GET_RESOURCES to:__IAVF_UNKNOWN_STATE
iavf 0000:06:0e.0: state transition from:__IAVF_UNKNOWN_STATE to:__IAVF_UNKNOWN_STATE

Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
Signed-off-by: Jun Zhang <xuejun.zhang@intel.com>
---
 drivers/net/ethernet/intel/iavf/iavf.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Paul Menzel June 8, 2022, 3:12 p.m. UTC | #1
Dear Jun, dear Przemyslaw,


Am 08.06.22 um 01:53 schrieb Jun Zhang:
> Fix debug prints, by adding missing state prints.

… to string conversion function.

> Extend iavf_state_str by strings for __IAVF_INIT_EXTENDED_CAPS and
> __IAVF_INIT_CONFIG_ADAPTER.
> Without this patch, when enabling debug prints for iavf.h, user will
> see:

Please do not break lines, just because a sentence ends, or add a blank 
line between paragraphs.

> iavf 0000:06:0e.0: state transition from:__IAVF_INIT_GET_RESOURCES to:__IAVF_UNKNOWN_STATE
> iavf 0000:06:0e.0: state transition from:__IAVF_UNKNOWN_STATE to:__IAVF_UNKNOWN_STATE

Add a Fixes: tag?

> Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>
> Signed-off-by: Jun Zhang <xuejun.zhang@intel.com>
> ---
>   drivers/net/ethernet/intel/iavf/iavf.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h
> index fda1198d2c00..cbcf0c710072 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf.h
> +++ b/drivers/net/ethernet/intel/iavf/iavf.h
> @@ -464,6 +464,10 @@ static inline const char *iavf_state_str(enum iavf_state_t state)
>   		return "__IAVF_INIT_VERSION_CHECK";
>   	case __IAVF_INIT_GET_RESOURCES:
>   		return "__IAVF_INIT_GET_RESOURCES";
> +	case __IAVF_INIT_EXTENDED_CAPS:
> +		return "__IAVF_INIT_EXTENDED_CAPS";
> +	case __IAVF_INIT_CONFIG_ADAPTER:
> +		return "__IAVF_INIT_CONFIG_ADAPTER";
>   	case __IAVF_INIT_SW:
>   		return "__IAVF_INIT_SW";
>   	case __IAVF_INIT_FAILED:

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h
index fda1198d2c00..cbcf0c710072 100644
--- a/drivers/net/ethernet/intel/iavf/iavf.h
+++ b/drivers/net/ethernet/intel/iavf/iavf.h
@@ -464,6 +464,10 @@  static inline const char *iavf_state_str(enum iavf_state_t state)
 		return "__IAVF_INIT_VERSION_CHECK";
 	case __IAVF_INIT_GET_RESOURCES:
 		return "__IAVF_INIT_GET_RESOURCES";
+	case __IAVF_INIT_EXTENDED_CAPS:
+		return "__IAVF_INIT_EXTENDED_CAPS";
+	case __IAVF_INIT_CONFIG_ADAPTER:
+		return "__IAVF_INIT_CONFIG_ADAPTER";
 	case __IAVF_INIT_SW:
 		return "__IAVF_INIT_SW";
 	case __IAVF_INIT_FAILED: