| Message ID | 20211025071636.818173-1-sasha.neftin@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [v1,1/1] igc: Remove unused phy type | expand |
Dear Sasha, On 25.10.21 09:16, Sasha Neftin wrote: Please add `igc_phy_none` to the summary to be as specific as possible. > _phy_none type not in use. Clean up the code accordingly, > and get rid of the unused enum line Please add a dot/period to the end of the sentence. > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_hw.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h > index 587db7483f25..76832e55cbbb 100644 > --- a/drivers/net/ethernet/intel/igc/igc_hw.h > +++ b/drivers/net/ethernet/intel/igc/igc_hw.h > @@ -55,7 +55,6 @@ enum igc_mac_type { > > enum igc_phy_type { > igc_phy_unknown = 0, > - igc_phy_none, > igc_phy_i225, > }; Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
On 10/25/2021 10:16, Sasha Neftin wrote: > _phy_none type not in use. Clean up the code accordingly, > and get rid of the unused enum line > > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_hw.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h > index 587db7483f25..76832e55cbbb 100644 > --- a/drivers/net/ethernet/intel/igc/igc_hw.h > +++ b/drivers/net/ethernet/intel/igc/igc_hw.h > @@ -55,7 +55,6 @@ enum igc_mac_type { > > enum igc_phy_type { > igc_phy_unknown = 0, > - igc_phy_none, > igc_phy_i225, > }; > Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>
diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h index 587db7483f25..76832e55cbbb 100644 --- a/drivers/net/ethernet/intel/igc/igc_hw.h +++ b/drivers/net/ethernet/intel/igc/igc_hw.h @@ -55,7 +55,6 @@ enum igc_mac_type { enum igc_phy_type { igc_phy_unknown = 0, - igc_phy_none, igc_phy_i225, };
_phy_none type not in use. Clean up the code accordingly, and get rid of the unused enum line Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> --- drivers/net/ethernet/intel/igc/igc_hw.h | 1 - 1 file changed, 1 deletion(-)