diff mbox series

[v1] e1000e: Add support for Comet Lake

Message ID 20191010101539.37043-1-sasha.neftin@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show
Series [v1] e1000e: Add support for Comet Lake | expand

Commit Message

Sasha Neftin Oct. 10, 2019, 10:15 a.m. UTC
Add devices ID's for the next LOM generations that will be
available on the next Intel Client platform (Comet Lake)
This patch provides the initial support for these devices

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
 drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
 drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
 2 files changed, 12 insertions(+)

Comments

Brown, Aaron F Oct. 23, 2019, 2:10 a.m. UTC | #1
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Sasha Neftin
> Sent: Thursday, October 10, 2019 3:16 AM
> To: intel-wired-lan@lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support for Comet Lake
> 
> Add devices ID's for the next LOM generations that will be
> available on the next Intel Client platform (Comet Lake)
> This patch provides the initial support for these devices
> 
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>  drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
>  drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>  2 files changed, 12 insertions(+)
> 

Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Paul Menzel Sept. 14, 2020, 7:35 a.m. UTC | #2
Dear Sasha, dear Jeff,


Am 10.10.19 um 12:15 schrieb Sasha Neftin:
> Add devices ID's for the next LOM generations that will be
> available on the next Intel Client platform (Comet Lake)
> This patch provides the initial support for these devices
> 
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
>   drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>   2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
> index eff75bd8a8f0..11fdc27faa82 100644
> --- a/drivers/net/ethernet/intel/e1000e/hw.h
> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
> @@ -86,6 +86,12 @@ struct e1000_hw;
>   #define E1000_DEV_ID_PCH_ICP_I219_V8		0x15E0
>   #define E1000_DEV_ID_PCH_ICP_I219_LM9		0x15E1
>   #define E1000_DEV_ID_PCH_ICP_I219_V9		0x15E2
> +#define E1000_DEV_ID_PCH_CMP_I219_LM10		0x0D4E
> +#define E1000_DEV_ID_PCH_CMP_I219_V10		0x0D4F
> +#define E1000_DEV_ID_PCH_CMP_I219_LM11		0x0D4C
> +#define E1000_DEV_ID_PCH_CMP_I219_V11		0x0D4D
> +#define E1000_DEV_ID_PCH_CMP_I219_LM12		0x0D53
> +#define E1000_DEV_ID_PCH_CMP_I219_V12		0x0D55
>   
>   #define E1000_REVISION_4	4
>   
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index cc4363e67072..2dedeed74cd4 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -7753,6 +7753,12 @@ static const struct pci_device_id e1000_pci_tbl[] = {
>   	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), board_pch_cnp },
>   	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), board_pch_cnp },
>   	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), board_pch_cnp },
> +	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), board_pch_cnp },
> +	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), board_pch_cnp },
> +	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), board_pch_cnp },
> +	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), board_pch_cnp },
> +	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), board_pch_spt },
> +	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), board_pch_spt },
>   
>   	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
>   };

This landed in Linux 5.5, and we would really like to see it in the 5.4 
stable series. As it’s just adding new PCI device codes, this sounds 
easily doable.

What is the process of getting it into the stable series? I remember the 
net subsystem having a different process than just adding `CC: 
stable@vger.kernel.org`, which is too late for this anyway, as it’s 
already in Linus’ master branch.


Kind regards,

Paul
Sasha Neftin Sept. 15, 2020, 6:48 a.m. UTC | #3
On 9/14/2020 10:35, Paul Menzel wrote:
> Dear Sasha, dear Jeff,
> 
> 
> Am 10.10.19 um 12:15 schrieb Sasha Neftin:
>> Add devices ID's for the next LOM generations that will be
>> available on the next Intel Client platform (Comet Lake)
>> This patch provides the initial support for these devices
>>
>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>>   2 files changed, 12 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h 
>> b/drivers/net/ethernet/intel/e1000e/hw.h
>> index eff75bd8a8f0..11fdc27faa82 100644
>> --- a/drivers/net/ethernet/intel/e1000e/hw.h
>> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
>> @@ -86,6 +86,12 @@ struct e1000_hw;
>>   #define E1000_DEV_ID_PCH_ICP_I219_V8        0x15E0
>>   #define E1000_DEV_ID_PCH_ICP_I219_LM9        0x15E1
>>   #define E1000_DEV_ID_PCH_ICP_I219_V9        0x15E2
>> +#define E1000_DEV_ID_PCH_CMP_I219_LM10        0x0D4E
>> +#define E1000_DEV_ID_PCH_CMP_I219_V10        0x0D4F
>> +#define E1000_DEV_ID_PCH_CMP_I219_LM11        0x0D4C
>> +#define E1000_DEV_ID_PCH_CMP_I219_V11        0x0D4D
>> +#define E1000_DEV_ID_PCH_CMP_I219_LM12        0x0D53
>> +#define E1000_DEV_ID_PCH_CMP_I219_V12        0x0D55
>>   #define E1000_REVISION_4    4
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c 
>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>> index cc4363e67072..2dedeed74cd4 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -7753,6 +7753,12 @@ static const struct pci_device_id 
>> e1000_pci_tbl[] = {
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), 
>> board_pch_cnp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), 
>> board_pch_cnp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), 
>> board_pch_cnp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), 
>> board_pch_cnp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), 
>> board_pch_cnp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), 
>> board_pch_cnp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), 
>> board_pch_cnp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), 
>> board_pch_spt },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), 
>> board_pch_spt },
>>       { 0, 0, 0, 0, 0, 0, 0 }    /* terminate list */
>>   };
> 
> This landed in Linux 5.5, and we would really like to see it in the 5.4 
> stable series. As it’s just adding new PCI device codes, this sounds 
> easily doable.
> 
> What is the process of getting it into the stable series? I remember the 
> net subsystem having a different process than just adding `CC: 
> stable@vger.kernel.org`, which is too late for this anyway, as it’s 
> already in Linus’ master branch.
Tony, can you help here?
(If I recall correctly Greg Kroah-Hartman own the stable version domain)
> 
> 
> Kind regards,
> 
> Paul
Nguyen, Anthony L Sept. 16, 2020, 11:33 p.m. UTC | #4
On Tue, 2020-09-15 at 09:48 +0300, Neftin, Sasha wrote:
> On 9/14/2020 10:35, Paul Menzel wrote:
> > Dear Sasha, dear Jeff,
> > 
> > 
> > Am 10.10.19 um 12:15 schrieb Sasha Neftin:
> > > Add devices ID's for the next LOM generations that will be
> > > available on the next Intel Client platform (Comet Lake)
> > > This patch provides the initial support for these devices
> > > 
> > > Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> > > ---

<snip>

> > This landed in Linux 5.5, and we would really like to see it in the
> > 5.4 
> > stable series. As it’s just adding new PCI device codes, this
> > sounds 
> > easily doable.
> > 
> > What is the process of getting it into the stable series? I
> > remember the 
> > net subsystem having a different process than just adding `CC: 
> > stable@vger.kernel.org`, which is too late for this anyway, as
> > it’s 
> > already in Linus’ master branch.
> 
> Tony, can you help here?
> (If I recall correctly Greg Kroah-Hartman own the stable version
> domain)

I've made the request see if this can be added to 5.4 stable.

Thanks,
Tony
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
index eff75bd8a8f0..11fdc27faa82 100644
--- a/drivers/net/ethernet/intel/e1000e/hw.h
+++ b/drivers/net/ethernet/intel/e1000e/hw.h
@@ -86,6 +86,12 @@  struct e1000_hw;
 #define E1000_DEV_ID_PCH_ICP_I219_V8		0x15E0
 #define E1000_DEV_ID_PCH_ICP_I219_LM9		0x15E1
 #define E1000_DEV_ID_PCH_ICP_I219_V9		0x15E2
+#define E1000_DEV_ID_PCH_CMP_I219_LM10		0x0D4E
+#define E1000_DEV_ID_PCH_CMP_I219_V10		0x0D4F
+#define E1000_DEV_ID_PCH_CMP_I219_LM11		0x0D4C
+#define E1000_DEV_ID_PCH_CMP_I219_V11		0x0D4D
+#define E1000_DEV_ID_PCH_CMP_I219_LM12		0x0D53
+#define E1000_DEV_ID_PCH_CMP_I219_V12		0x0D55
 
 #define E1000_REVISION_4	4
 
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index cc4363e67072..2dedeed74cd4 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -7753,6 +7753,12 @@  static const struct pci_device_id e1000_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), board_pch_spt },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), board_pch_spt },
 
 	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
 };