diff mbox series

[1/2] ixgbe: fix AF_XDP tx byte count

Message ID 20190404163655.27662-1-jeffrey.t.kirsher@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show
Series [1/2] ixgbe: fix AF_XDP tx byte count | expand

Commit Message

Kirsher, Jeffrey T April 4, 2019, 4:36 p.m. UTC 
From: William Tu <u9012063@gmail.com>

The tx bytecount is done twice.  When running
'./xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
The avg packet size is 120 instead of 60. So remove the
extra one.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bowers, AndrewX April 8, 2019, 7:41 p.m. UTC | #1 
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Thursday, April 4, 2019 9:37 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: William Tu <u9012063@gmail.com>
> Subject: [Intel-wired-lan] [1/2] ixgbe: fix AF_XDP tx byte count
> 
> From: William Tu <u9012063@gmail.com>
> 
> The tx bytecount is done twice.  When running './xdpsock -t -N -i eth3' and 'ip
> -s link show dev eth3'
> The avg packet size is 120 instead of 60. So remove the extra one.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
>  1 file changed, 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
index bfe95ce0bd7f..71b8474a9b4c 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
@@ -704,7 +704,6 @@  bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector,
 			xsk_frames++;
 
 		tx_bi->xdpf = NULL;
-		total_bytes += tx_bi->bytecount;
 
 		tx_bi++;
 		tx_desc++;