From patchwork Fri Apr 13 18:16:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 898074 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="tNFxzGc0"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40N5kN3Z55z9rvt for ; Sat, 14 Apr 2018 04:23:23 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 39E9588E0F; Fri, 13 Apr 2018 18:23:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RpBSk3iGs07K; Fri, 13 Apr 2018 18:23:21 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 697AD88E08; Fri, 13 Apr 2018 18:23:21 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 49BD41C1F91 for ; Fri, 13 Apr 2018 18:23:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4621989BE2 for ; Fri, 13 Apr 2018 18:23:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nqHIU7KxlJTx for ; Fri, 13 Apr 2018 18:23:19 +0000 (UTC) X-Greylist: delayed 00:06:16 by SQLgrey-1.7.6 Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by hemlock.osuosl.org (Postfix) with ESMTPS id 89BF389AB6 for ; Fri, 13 Apr 2018 18:23:19 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id y69so6519707pfb.5 for ; Fri, 13 Apr 2018 11:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=vuTYSWivOZGDl6fRr8TKvpmcq7cZ8Cxrv4owI+OTZUk=; b=tNFxzGc0BBKMtYW40rWin7dTVJvSBlNUXM3+xvmzITZkhjappbY4EmdV9rsu/L9til 7WI7QYO7E7W1rR5jjEnogFmI3EfJUsD2z75CE6bA+VPho/Lf6RsPspIvTjj8IwHsyJ/D 6Wum7sAOoM/FB0fhpVMJ2ytN1EbchmNg10HGhDiXkYQFy/NVvyuN73Zpwd+2TYE8VuwO 6ijJ1crcFZu5INs3IM2iP8MAza5bUmlmeJn6QaBEJcQQIWwvMVdhaItWpamY9wNgLmTY xyTSqJUGPcEHYtuEuka13KuUBTgeAx+qZyesIJc4a9E6MHbkXQBVKAq1QBmFTNA6YqJI z7kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vuTYSWivOZGDl6fRr8TKvpmcq7cZ8Cxrv4owI+OTZUk=; b=rtH+FKMDWLGxbjmMHgYWEbnQhZa/IJwtffnT4uIqk/cPmOA+wjiuQh0SoJfKvWee2v qTswvkJ4UzLikoUF8ni+XRI2/EY6tNRC8UtL8gd7vyf6toJhQYc6n21+Elw75sHfsEu8 JQiJYdaLRKlPc1/fJKW2OuKcsCbUs+1XUK9NvQnr1wyuilCTByA9kKE53F70pPK/S3Jh mYXBTVtEnGVV1wpK70ZTE+mQAWlLPFjDSsPGQKcP8wcoLmcmm3gETpGv9pAwmplg9MFI XGuUo39PgK/rEiM0G5oZ7ctnQXa1vkkUh6cbtkuJL2XjrjVEqNAl0TbH4Ur7F3mB0AQu L+bw== X-Gm-Message-State: ALQs6tBetDCRuWGzEFXRx1rO8NJKFSFkq9vbOfMhiPe/uptxRjnvHi4o kOqMQIqFDXLVjvUy3Pio8cA0PQ== X-Google-Smtp-Source: AIpwx4/+yAWptRyxoTPgUyaVqiScbjtI+C0sObKsRXO1ODVuzgHvnm4w+u1TyCimtkNdr7KdT+ceug== X-Received: by 10.99.188.9 with SMTP id q9mr4725688pge.381.1523643423354; Fri, 13 Apr 2018 11:17:03 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([75.53.12.129]) by smtp.gmail.com with ESMTPSA id t137sm11418545pgc.16.2018.04.13.11.17.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Apr 2018 11:17:02 -0700 (PDT) From: Jakub Kicinski To: Bjorn Helgaas Date: Fri, 13 Apr 2018 11:16:38 -0700 Message-Id: <20180413181638.6424-1-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.16.2 Subject: [Intel-wired-lan] [PATCH] PCI: Add PCIe to pcie_print_link_status() messages X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub Kicinski , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Gilboa , intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org, Tariq Toukan , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Currently the pcie_print_link_status() will print PCIe bandwidth and link width information but does not mention it is pertaining to the PCIe. Since this and related functions are used exclusively by networking drivers today users may get confused into thinking that it's the NIC bandwidth that is being talked about. Insert a "PCIe" into the messages. Signed-off-by: Jakub Kicinski --- drivers/pci/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index aa86e904f93c..73a0a4993f6a 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5273,11 +5273,11 @@ void pcie_print_link_status(struct pci_dev *dev) bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); if (bw_avail >= bw_cap) - pci_info(dev, "%u.%03u Gb/s available bandwidth (%s x%d link)\n", + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", bw_cap / 1000, bw_cap % 1000, PCIE_SPEED2STR(speed_cap), width_cap); else - pci_info(dev, "%u.%03u Gb/s available bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", + pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", bw_avail / 1000, bw_avail % 1000, PCIE_SPEED2STR(speed), width, limiting_dev ? pci_name(limiting_dev) : "",