| Message ID | 1622480149-29979-1-git-send-email-michal.maloszewski@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [net,v1] i40e: Add additional info to PHY type error | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Michal Maloszewski > Sent: Monday, May 31, 2021 9:56 AM > To: intel-wired-lan@lists.osuosl.org > Cc: Maloszewski, Michal <michal.maloszewski@intel.com>; Cieplicki, LukaszX > <lukaszx.cieplicki@intel.com> > Subject: [Intel-wired-lan] [PATCH net v1] i40e: Add additional info to PHY > type error > > From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com> > > In case of PHY type error occurs, the message was too generic. > Add additional info to PHY type error indicating that it can be wrong cable > connected. > > Fixes: 124ed15bf126 ("i40e: Add dual speed module support") > Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com> > Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com> > --- > drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> (A Contingent Worker at Intel)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 45f5dc2..7a1d2d5 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -971,7 +971,7 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw, default: /* if we got here and link is up something bad is afoot */ netdev_info(netdev, - "WARNING: Link is up but PHY type 0x%x is not recognized.\n", + "WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n", hw_link_info->phy_type); }