mbox series

[v4,00/15] ice: Separate TSPLL from PTP and clean up

Message ID 20250501-kk-tspll-improvements-alignment-v4-0-24c83d0ce7a8@intel.com
Headers show
Series ice: Separate TSPLL from PTP and clean up | expand

Message

Keller, Jacob E May 1, 2025, 10:54 p.m. UTC 
Separate TSPLL related functions and definitions from all PTP-related
files and clean up the code by implementing multiple helpers.

Adjust TSPLL wait times and fall back to TCXO on lock failure to ensure
proper init flow of TSPLL.

Change default clock source for E825-C from TCXO to TIME_REF if its
available.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Changes in v4:
- Rebase onto Intel Wired LAN dev-queue
- Restore use of string choice helpers
- Restore use of ice_debug()
- Improve title of commit to change the default clock source
- Link to v3: https://lore.kernel.org/r/20250430-kk-tspll-improvements-alignment-v3-0-ab8472e86204@intel.com

Changes in v3:
- Add SPDX headers to new files
- Fix .dest_dev assignments in patch #1
- Drop accidental re-sizing of e82x misc15 field in v2 #2
- Split v2 patch #6, with behavioral changes in new patch #3 and #8
- Split v2 patch #3, with removal of E825-C array to its own patch #4
- Fix kernel doc warnings
- Add a patch to also update the default E825-C clock source to TIME_REF
- Link to v2: https://lore.kernel.org/intel-wired-lan/20250409122830.1977644-12-karol.kolacinski@intel.com/

---
Jacob Keller (4):
      ice: fix E825-C TSPLL register definitions
      ice: clear time_sync_en field for E825-C during reprogramming
      ice: read TSPLL registers again before reporting status
      ice: default to TIME_REF instead of TXCO on E825-C

Karol Kolacinski (11):
      ice: move TSPLL functions to a separate file
      ice: rename TSPLL and CGU functions and definitions
      ice: remove ice_tspll_params_e825 definitions
      ice: use designated initializers for TSPLL consts
      ice: add TSPLL log config helper
      ice: add ICE_READ/WRITE_CGU_REG_OR_DIE helpers
      ice: use bitfields instead of unions for CGU regs
      ice: add multiple TSPLL helpers
      ice: wait before enabling TSPLL
      ice: fall back to TCXO on TSPLL lock fail
      ice: move TSPLL init calls to ice_ptp.c

 drivers/net/ethernet/intel/ice/ice.h            |   1 +
 drivers/net/ethernet/intel/ice/ice_cgu_regs.h   | 181 --------
 drivers/net/ethernet/intel/ice/ice_common.h     |  58 +++
 drivers/net/ethernet/intel/ice/ice_ptp_consts.h | 177 +-------
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h     |  54 +--
 drivers/net/ethernet/intel/ice/ice_tspll.h      |  31 ++
 drivers/net/ethernet/intel/ice/ice_type.h       |  20 +-
 drivers/net/ethernet/intel/ice/ice_common.c     |  71 ++-
 drivers/net/ethernet/intel/ice/ice_ptp.c        |  14 +-
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c     | 564 +-----------------------
 drivers/net/ethernet/intel/ice/ice_tspll.c      | 518 ++++++++++++++++++++++
 drivers/net/ethernet/intel/ice/Makefile         |   2 +-
 12 files changed, 712 insertions(+), 979 deletions(-)
---
base-commit: e3945f0d3dac6bf6231a5501766c3614cd6f7f45
change-id: 20250417-kk-tspll-improvements-alignment-2cb078adf961

Best regards,