mbox series

[net-next,v6,0/3] iavf: Fix init and watchdog state machines

Message ID 20210819084731.2344-1-mateusz.palczewski@intel.com
Headers show
Series iavf: Fix init and watchdog state machines | expand

Message

Mateusz Palczewski Aug. 19, 2021, 8:47 a.m. UTC 
Use single state machine for driver initialization
and for service initialized driver. The init state
machine implemented in init_task() is merged
into the watchdog_task(). The init_task() function
is removed.

---
v6: Fixed that patch so that it applies on next-queue tree
v5: Fixed the patch so that it applies on net-next tree
v4: Removed unnecessary line
v3: Added new file to patch series
v2: Splitted the patch into 2 to make them smaller
---

Jan Sokolowski (3):
  iavf: Refactor iavf state machine tracking
  iavf: Add __IAVF_INIT_FAILED state
  iavf: Fix init and watchdog state machines

 drivers/net/ethernet/intel/iavf/iavf.h        |  12 +-
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 192 ++++++++----------
 .../net/ethernet/intel/iavf/iavf_virtchnl.c   |   2 +-
 3 files changed, 101 insertions(+), 105 deletions(-)

Comments

Tony Nguyen Aug. 20, 2021, 5:49 p.m. UTC | #1 
On Thu, 2021-08-19 at 08:47 +0000, Mateusz Palczewski wrote:
> Use single state machine for driver initialization
> and for service initialized driver. The init state
> machine implemented in init_task() is merged
> into the watchdog_task(). The init_task() function
> is removed.

I've applied this, however, I've removed the fixes tags. It's not clear
to me how or what the refactor or single state machine is fixing. If
you disagree, please resubmit with explanations of the current problem
and how this fixes it in the descriptions.

Thanks,
Tony