mbox series

[v3,0/9] igc: Add XDP support

Message ID 20201030210351.46482-1-andre.guedes@intel.com
Headers show
Series igc: Add XDP support | expand

Message

Andre Guedes Oct. 30, 2020, 9:03 p.m. UTC 
Hi all,

This is the third version of this series which adds XDP support to igc driver.

The main changes from v2 are:

    - Moved functions that belong to the driver's hot path to igc_main.c to
      allow the compiler to inline them if convenient.
    - Squashed ndo_xdp_xmit patch into XDP_REDIRECT patch.

v2 is here:

    https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201028201943.93147-1-andre.guedes@intel.com/

v1 is here:

    https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201009025349.4037-1-andre.guedes@intel.com/

Cheers,
Andre


Andre Guedes (9):
  igc: Fix igc_ptp_rx_pktstamp()
  igc: Remove unused argument from igc_tx_cmd_type()
  igc: Introduce igc_rx_buffer_flip() helper
  igc: Introduce igc_get_rx_frame_truesize() helper
  igc: Refactor rx timestamp handling
  igc: Add set/clear large buffer helpers
  igc: Add initial XDP support
  igc: Add support for XDP_TX action
  igc: Add support for XDP_REDIRECT action

 drivers/net/ethernet/intel/igc/Makefile   |   2 +-
 drivers/net/ethernet/intel/igc/igc.h      |  18 +-
 drivers/net/ethernet/intel/igc/igc_main.c | 431 +++++++++++++++++++---
 drivers/net/ethernet/intel/igc/igc_ptp.c  |  89 +++--
 drivers/net/ethernet/intel/igc/igc_xdp.c  |  60 +++
 drivers/net/ethernet/intel/igc/igc_xdp.h  |  13 +
 6 files changed, 512 insertions(+), 101 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/igc/igc_xdp.c
 create mode 100644 drivers/net/ethernet/intel/igc/igc_xdp.h

Comments

Maciej Fijalkowski Nov. 2, 2020, 6:31 p.m. UTC | #1 
On Fri, Oct 30, 2020 at 02:03:42PM -0700, Andre Guedes wrote:
> Hi all,
> 
> This is the third version of this series which adds XDP support to igc driver.
> 
> The main changes from v2 are:
> 
>     - Moved functions that belong to the driver's hot path to igc_main.c to
>       allow the compiler to inline them if convenient.
>     - Squashed ndo_xdp_xmit patch into XDP_REDIRECT patch.
> 
> v2 is here:
> 
>     https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201028201943.93147-1-andre.guedes@intel.com/
> 
> v1 is here:
> 
>     https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201009025349.4037-1-andre.guedes@intel.com/
> 
> Cheers,
> Andre

I had only minor comments/questions for this version, so you can take my:

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

for series.

> 
> 
> Andre Guedes (9):
>   igc: Fix igc_ptp_rx_pktstamp()
>   igc: Remove unused argument from igc_tx_cmd_type()
>   igc: Introduce igc_rx_buffer_flip() helper
>   igc: Introduce igc_get_rx_frame_truesize() helper
>   igc: Refactor rx timestamp handling
>   igc: Add set/clear large buffer helpers
>   igc: Add initial XDP support
>   igc: Add support for XDP_TX action
>   igc: Add support for XDP_REDIRECT action
> 
>  drivers/net/ethernet/intel/igc/Makefile   |   2 +-
>  drivers/net/ethernet/intel/igc/igc.h      |  18 +-
>  drivers/net/ethernet/intel/igc/igc_main.c | 431 +++++++++++++++++++---
>  drivers/net/ethernet/intel/igc/igc_ptp.c  |  89 +++--
>  drivers/net/ethernet/intel/igc/igc_xdp.c  |  60 +++
>  drivers/net/ethernet/intel/igc/igc_xdp.h  |  13 +
>  6 files changed, 512 insertions(+), 101 deletions(-)
>  create mode 100644 drivers/net/ethernet/intel/igc/igc_xdp.c
>  create mode 100644 drivers/net/ethernet/intel/igc/igc_xdp.h
> 
> -- 
> 2.28.0
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Andre Guedes Nov. 3, 2020, 11:41 p.m. UTC | #2 
Quoting Maciej Fijalkowski (2020-11-02 10:31:29)
> On Fri, Oct 30, 2020 at 02:03:42PM -0700, Andre Guedes wrote:
> > Hi all,
> > 
> > This is the third version of this series which adds XDP support to igc driver.
> > 
> > The main changes from v2 are:
> > 
> >     - Moved functions that belong to the driver's hot path to igc_main.c to
> >       allow the compiler to inline them if convenient.
> >     - Squashed ndo_xdp_xmit patch into XDP_REDIRECT patch.
> > 
> > v2 is here:
> > 
> >     https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201028201943.93147-1-andre.guedes@intel.com/
> > 
> > v1 is here:
> > 
> >     https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201009025349.4037-1-andre.guedes@intel.com/
> > 
> > Cheers,
> > Andre
> 
> I had only minor comments/questions for this version, so you can take my:
> 
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> 
> for series.

Thanks for the review, Maceij! I'm adding your Reviewed-by to the next version
of this series I'm submitting soon.