| Message ID | 20200109010818.1326575-1-jacob.e.keller@intel.com |
|---|---|
| Headers | show |
| Series | devlink region snapshot triggering | expand |
Thu, Jan 09, 2020 at 02:08:15AM CET, jacob.e.keller@intel.com wrote: >This series consists of patches to enable devlink to request a snapshot via >a new DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT. > >The netdevsim driver is modified to support the new trigger_snapshot >callback as an example of how this can be used. > >There is also some fix ups for s/shapshot/snapshot/ in documentation >and the devlink_snapshot_id_get function. You can already trigger health reporter dump from userspace. Why don't you use health reporter? > >Jacob Keller (3): > devlink: correct misspelling of snapshot > doc: fix typo of snapshot in documentation > devlink: add support for triggering snapshots from userspace > >The last patch is a patch to the iproute2 project to implement support for >the new command. > >Jacob Keller (1): > devlink: add support for DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT > > Documentation/admin-guide/devices.txt | 2 +- > Documentation/media/v4l-drivers/meye.rst | 2 +- > drivers/net/ethernet/mellanox/mlx4/crdump.c | 6 +-- > drivers/net/netdevsim/dev.c | 37 +++++++++++----- > include/net/devlink.h | 14 +++--- > include/uapi/linux/devlink.h | 2 + > net/core/devlink.c | 49 ++++++++++++++++++--- > 7 files changed, 85 insertions(+), 27 deletions(-) > > devlink/devlink.c | 20 ++++++++++++++++++++ > include/uapi/linux/devlink.h | 2 ++ > 2 files changed, 22 insertions(+) > >-- >2.25.0.rc1 >
On 1/8/2020 11:00 PM, Jiri Pirko wrote: > Thu, Jan 09, 2020 at 02:08:15AM CET, jacob.e.keller@intel.com wrote: >> There is also some fix ups for s/shapshot/snapshot/ in documentation >> and the devlink_snapshot_id_get function. > > You can already trigger health reporter dump from userspace. Why don't > you use health reporter? > Hmm. Mainly because the specific things I wanted to expose through regions aren't really "health" information. Thanks, Jake
Hmm, could you send patchsets like this one to netdev mailing list? Thanks! Thu, Jan 09, 2020 at 02:08:15AM CET, jacob.e.keller@intel.com wrote: >This series consists of patches to enable devlink to request a snapshot via >a new DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT. > >The netdevsim driver is modified to support the new trigger_snapshot >callback as an example of how this can be used. > >There is also some fix ups for s/shapshot/snapshot/ in documentation >and the devlink_snapshot_id_get function. > >Jacob Keller (3): > devlink: correct misspelling of snapshot > doc: fix typo of snapshot in documentation > devlink: add support for triggering snapshots from userspace > >The last patch is a patch to the iproute2 project to implement support for >the new command. > >Jacob Keller (1): > devlink: add support for DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT > > Documentation/admin-guide/devices.txt | 2 +- > Documentation/media/v4l-drivers/meye.rst | 2 +- > drivers/net/ethernet/mellanox/mlx4/crdump.c | 6 +-- > drivers/net/netdevsim/dev.c | 37 +++++++++++----- > include/net/devlink.h | 14 +++--- > include/uapi/linux/devlink.h | 2 + > net/core/devlink.c | 49 ++++++++++++++++++--- > 7 files changed, 85 insertions(+), 27 deletions(-) > > devlink/devlink.c | 20 ++++++++++++++++++++ > include/uapi/linux/devlink.h | 2 ++ > 2 files changed, 22 insertions(+) > >-- >2.25.0.rc1 >