diff mbox series

fix wifi unable to connect on brcmfmac driver

Message ID PN3PR01MB959759306E85F2F6E0776C16B867A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM
State New
Headers show
Series fix wifi unable to connect on brcmfmac driver | expand

Commit Message

Aditya Garg May 28, 2025, 8:18 a.m. UTC 
Commit "41638606054a" (Mark authorization completed on driver indication
during 4-way HS offload) introduced a regression causing wifi unable to
connect on brcmfmac driver. This commit reverts the change to restore
the previous behavior.

Currently, Fedora ships wpa_supplicant with this commit reverted.

Link: https://src.fedoraproject.org/rpms/wpa_supplicant/pull-request/25#request_diff
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2302577

Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
 wpa_supplicant/events.c | 25 ++++++++-----------------
 1 file changed, 8 insertions(+), 17 deletions(-)
diff mbox series

Patch

diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
index fe8e45e07..a36f393a5 100644
--- a/wpa_supplicant/events.c
+++ b/wpa_supplicant/events.c
@@ -4492,23 +4492,14 @@  static void wpa_supplicant_event_assoc(struct wpa_supplicant *wpa_s,
 		eapol_sm_notify_eap_success(wpa_s->eapol, true);
 	} else if ((wpa_s->drv_flags & WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_PSK) &&
 		   wpa_key_mgmt_wpa_psk(wpa_s->key_mgmt)) {
-		if (already_authorized) {
-			/*
-			 * We are done; the driver will take care of RSN 4-way
-			 * handshake.
-			 */
-			wpa_supplicant_cancel_auth_timeout(wpa_s);
-			wpa_supplicant_set_state(wpa_s, WPA_COMPLETED);
-			eapol_sm_notify_portValid(wpa_s->eapol, true);
-			eapol_sm_notify_eap_success(wpa_s->eapol, true);
-		} else {
-			/* Update port, WPA_COMPLETED state from the
-			 * EVENT_PORT_AUTHORIZED handler when the driver is done
-			 * with the 4-way handshake.
-			 */
-			wpa_msg(wpa_s, MSG_DEBUG,
-				"ASSOC INFO: wait for driver port authorized indication");
-		}
+		/*
+		 * We are done; the driver will take care of RSN 4-way
+		 * handshake.
+		 */
+		wpa_supplicant_cancel_auth_timeout(wpa_s);
+		wpa_supplicant_set_state(wpa_s, WPA_COMPLETED);
+		eapol_sm_notify_portValid(wpa_s->eapol, true);
+		eapol_sm_notify_eap_success(wpa_s->eapol, true);
 	} else if ((wpa_s->drv_flags & WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_8021X) &&
 		   wpa_key_mgmt_wpa_ieee8021x(wpa_s->key_mgmt)) {
 		/*