diff mbox

Android: Remove superfluous OpenSSL include paths.

Message ID CAH7ZN-zwyONhJpe7QnVSzCKp+PCaGNNwkVrvcBg1pHvE7NjXmA@mail.gmail.com
State Deferred
Headers show

Commit Message

Dmitry Shmidt Jan. 29, 2015, 7:07 p.m. UTC
From c91a1dd0652b0083f66a9714d4396378cd049e3d Mon Sep 17 00:00:00 2001
From: Adam Langley <agl@google.com>
Date: Thu, 22 Jan 2015 17:13:10 -0800
Subject: [PATCH] Android: Remove superfluous OpenSSL include paths.

The libcrypto and libssl modules (and their respective static and host
versions) use LOCAL_EXPORT_C_INCLUDE_DIRS thus just including the module
is sufficient.

Change-Id: If8722a70dd82aad34d4a203c2af46110c98f42dc
Signed-off-by: Dmitry Shmidt <dimitrysh@google.com>
---
 hostapd/Android.mk        | 1 -
 hs20/client/Android.mk    | 1 -
 wpa_supplicant/Android.mk | 1 -
 3 files changed, 3 deletions(-)

--.
2.2.0.rc0.207.ga3a616c

Comments

Jouni Malinen Jan. 30, 2015, 9:14 a.m. UTC | #1
On Thu, Jan 29, 2015 at 11:07:18AM -0800, Dmitry Shmidt wrote:
> The libcrypto and libssl modules (and their respective static and host
> versions) use LOCAL_EXPORT_C_INCLUDE_DIRS thus just including the module
> is sufficient.

This breaks build with AOSP (android-5.0.2_r1) for me:

external/wpa_supplicant_8/hostapd/src/crypto/crypto_openssl.c:10:30: fatal error: openssl/opensslv.h: No such file or directory
 #include <openssl/opensslv.h>

(I don't see LOCAL_EXPORT_C_INCLUDE_DIRS anywhere in external/openssl at
least as far as that specific snapshot from AOSP is concerned.)
Dmitry Shmidt Jan. 30, 2015, 7:16 p.m. UTC | #2
On Fri, Jan 30, 2015 at 1:14 AM, Jouni Malinen <j@w1.fi> wrote:
> On Thu, Jan 29, 2015 at 11:07:18AM -0800, Dmitry Shmidt wrote:
>> The libcrypto and libssl modules (and their respective static and host
>> versions) use LOCAL_EXPORT_C_INCLUDE_DIRS thus just including the module
>> is sufficient.
>
> This breaks build with AOSP (android-5.0.2_r1) for me:
>
> external/wpa_supplicant_8/hostapd/src/crypto/crypto_openssl.c:10:30: fatal error: openssl/opensslv.h: No such file or directory
>  #include <openssl/opensslv.h>
>
> (I don't see LOCAL_EXPORT_C_INCLUDE_DIRS anywhere in external/openssl at
> least as far as that specific snapshot from AOSP is concerned.)

You are right, it is not backward-compatible with AOSP L-Release.
I'll try to be more careful next time. Let's wait till next release then.

>
> --
> Jouni Malinen                                            PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP@lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
diff mbox

Patch

diff --git a/hostapd/Android.mk b/hostapd/Android.mk
index 6fcefdd..123d2c9 100644
--- a/hostapd/Android.mk
+++ b/hostapd/Android.mk
@@ -45,7 +45,6 @@  endif
 INCLUDES = $(LOCAL_PATH)
 INCLUDES += $(LOCAL_PATH)/src
 INCLUDES += $(LOCAL_PATH)/src/utils
-INCLUDES += external/openssl/include
 INCLUDES += system/security/keystore/include
 ifdef CONFIG_DRIVER_NL80211
 ifneq ($(wildcard external/libnl),)
diff --git a/hs20/client/Android.mk b/hs20/client/Android.mk
index 2457e13..ced6d8d 100644
--- a/hs20/client/Android.mk
+++ b/hs20/client/Android.mk
@@ -4,7 +4,6 @@  INCLUDES = $(LOCAL_PATH)
 INCLUDES += $(LOCAL_PATH)/../../src/utils
 INCLUDES += $(LOCAL_PATH)/../../src/common
 INCLUDES += $(LOCAL_PATH)/../../src
-INCLUDES += external/openssl/include
 INCLUDES += external/libxml2/include
 INCLUDES += external/curl/include
 INCLUDES += external/webkit/Source/WebKit/gtk
diff --git a/wpa_supplicant/Android.mk b/wpa_supplicant/Android.mk
index 579582b..2ec99ad 100644
--- a/wpa_supplicant/Android.mk
+++ b/wpa_supplicant/Android.mk
@@ -61,7 +61,6 @@  INCLUDES += $(LOCAL_PATH)/src/rsn_supp
 INCLUDES += $(LOCAL_PATH)/src/tls
 INCLUDES += $(LOCAL_PATH)/src/utils
 INCLUDES += $(LOCAL_PATH)/src/wps
-INCLUDES += external/openssl/include
 INCLUDES += system/security/keystore/include
 ifdef CONFIG_DRIVER_NL80211
 ifneq ($(wildcard external/libnl),)