| Message ID | CA+zir25xRo6uPB0HfgsmTePH3zBq48kRx-oy6xCkH46navjdAA@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | DPP: Remove argument requirement for DPP push button command | expand |
On Wed, Apr 19, 2023 at 01:12:30PM +1000, Andrew Pope wrote: > The hostapd_cli command to initiate DPP push button mode mandates at > least one argument to be provided. Arguments provided to the command > are used to optionally supply configuration options when running in > this mode. They are not strictly required for DPP push button mode to > start. This patch removes the min requirement check on the command. Thanks, applied.
diff --git a/hostapd/hostapd_cli.c b/hostapd/hostapd_cli.c index 95edea8..646dfc5 100644 --- a/hostapd/hostapd_cli.c +++ b/hostapd/hostapd_cli.c @@ -1529,7 +1529,7 @@ static int hostapd_cli_cmd_dpp_stop_chirp(struct wpa_ctrl *ctrl, int argc, static int hostapd_cli_cmd_dpp_push_button(struct wpa_ctrl *ctrl, int argc, char *argv[]) { - return hostapd_cli_cmd(ctrl, "DPP_PUSH_BUTTON", 1, argc, argv); + return hostapd_cli_cmd(ctrl, "DPP_PUSH_BUTTON", 0, argc, argv); } #endif /* CONFIG_DPP3 */
The hostapd_cli command to initiate DPP push button mode mandates at least one argument to be provided. Arguments provided to the command are used to optionally supply configuration options when running in this mode. They are not strictly required for DPP push button mode to start. This patch removes the min requirement check on the command. Signed-off-by: Andrew Pope (andrew.pope@morsemicro.com) --- hostapd/hostapd_cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) #endif /* CONFIG_DPP */ ---