From patchwork Thu Jun 28 16:42:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timo Juhani Lindfors X-Patchwork-Id: 167925 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from maxx.maxx.shmoo.com (maxx.shmoo.com [205.134.188.171]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "maxx.shmoo.com", Issuer "CA Cert Signing Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7AC12B7001 for ; Fri, 29 Jun 2012 02:42:19 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 7F6929D1EF; Thu, 28 Jun 2012 12:42:16 -0400 (EDT) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HCZzqbcYodjr; Thu, 28 Jun 2012 12:42:16 -0400 (EDT) Received: from maxx.shmoo.com (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 1C19C17C014; Thu, 28 Jun 2012 12:42:12 -0400 (EDT) X-Original-To: mailman-post+hostap@maxx.shmoo.com Delivered-To: mailman-post+hostap@maxx.shmoo.com Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id D596E17C014 for ; Thu, 28 Jun 2012 12:42:10 -0400 (EDT) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ah+vrBaMi-q3 for ; Thu, 28 Jun 2012 12:42:05 -0400 (EDT) Received: from kirsi1.inet.fi (mta-out.inet.fi [195.156.147.13]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 5B23C17C013 for ; Thu, 28 Jun 2012 12:42:05 -0400 (EDT) Received: from sauna (84.248.66.131) by kirsi1.inet.fi (8.5.140.03) id 4FD08A2301475DEF for hostap@lists.shmoo.com; Thu, 28 Jun 2012 19:42:04 +0300 Received: from lindi by sauna with local (Exim 4.72) (envelope-from ) id 1SkHn9-0000yK-U0 for hostap@lists.shmoo.com; Thu, 28 Jun 2012 19:42:03 +0300 From: Timo Juhani Lindfors To: hostap@lists.shmoo.com Subject: Re: bug 456 [REGRESSION 0.7.3-6 => 1.0-2] WPA-PSK + openmoko: unable to get DHCPACK References: <844npx6n54.fsf@sauna.l.org> Date: Thu, 28 Jun 2012 19:42:03 +0300 In-Reply-To: <844npx6n54.fsf@sauna.l.org> (Timo Juhani Lindfors's message of "Wed, 27 Jun 2012 13:54:15 +0300") Message-ID: <84fw9f5qxw.fsf@sauna.l.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 X-BeenThere: hostap@lists.shmoo.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: HostAP Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: hostap-bounces@lists.shmoo.com Errors-To: hostap-bounces@lists.shmoo.com Hi, I bisected this down to commit 180cdf45a415969b851aab530e9b23606032941a Author: Jouni Malinen Date: Tue Oct 18 23:04:36 2011 +0300 wext: Increase scan timeout from 5 to 10 seconds Some dualband cards can use more than five seconds to run through a full scan, so increase the timeout to avoid hitting the missing scan completed event workaround. Here's the log for completeness: git bisect start # good: [0b86f67a2970403d1b1b6d34ce49f5485ef5dbb3] Add wpa_gui-qt4 translation files into build git bisect good 0b86f67a2970403d1b1b6d34ce49f5485ef5dbb3 # bad: [106233504ab2f55dd5f5b6454e2443aed7914383] Update version number for 1.0 release. git bisect bad 106233504ab2f55dd5f5b6454e2443aed7914383 # good: [2a0cd0670b08ae84796352e17279b792e26fa8ba] OpenSSL: Add access to Android certificates git bisect good 2a0cd0670b08ae84796352e17279b792e26fa8ba # good: [a4cba8f1e208c95218f89daec01cbcb59d97dc6c] Use sched_scan in driver init git bisect good a4cba8f1e208c95218f89daec01cbcb59d97dc6c # bad: [1dc77cda118410904886776194f56f3623f830b4] Make crypto_hash_init() easier for static analyzers git bisect bad 1dc77cda118410904886776194f56f3623f830b4 # bad: [3803bd331de647bb99a80db00cf19361b0b04be2] TLS: Validate RSA ClientKeyExchange length field git bisect bad 3803bd331de647bb99a80db00cf19361b0b04be2 # good: [ea08bfe3847c7075c7fab802441a519dd02c7654] netlink: Do not use void pointer for pointer arithmetic git bisect good ea08bfe3847c7075c7fab802441a519dd02c7654 # bad: [9fb0407055112d9f24cd451ce880326197988a61] nl80211: Use a wrapper for genlmsg_put git bisect bad 9fb0407055112d9f24cd451ce880326197988a61 # bad: [9b90955ec706905d1c5b864885d252ebf7ddba4e] AP: Pass only bssid/addr/wds to EVENT_RX_FROM_UNKNOWN git bisect bad 9b90955ec706905d1c5b864885d252ebf7ddba4e # bad: [7a25f29d890f56c4df81143f8b5eb42fb5eeeb07] Interworking: Use unsigned integer for bitfield git bisect bad 7a25f29d890f56c4df81143f8b5eb42fb5eeeb07 # good: [54e9c5fc6976c4cd1fd4cccf2b7dadaad2c4e437] EAP: Clear ClientTimeout back to default value in INITIALIZE git bisect good 54e9c5fc6976c4cd1fd4cccf2b7dadaad2c4e437 # bad: [180cdf45a415969b851aab530e9b23606032941a] wext: Increase scan timeout from 5 to 10 seconds git bisect bad 180cdf45a415969b851aab530e9b23606032941a # good: [0597a5b59d731142d53bd854b18f802fb2e01046] Add log_level command git bisect good 0597a5b59d731142d53bd854b18f802fb2e01046 Any idea what the _real_ issue here could be? Surely increasing timeout should not cause regressions? diff --git a/src/drivers/driver_wext.c b/src/drivers/driver_wext.c index 9fa356b..e44aeac 100644 --- a/src/drivers/driver_wext.c +++ b/src/drivers/driver_wext.c @@ -1007,7 +1007,7 @@ int wpa_driver_wext_scan(void *priv, struct wpa_driver_scan_params *params) /* Not all drivers generate "scan completed" wireless event, so try to * read results after a timeout. */ - timeout = 5; + timeout = 10; if (drv->scan_complete_events) { /* * The driver seems to deliver SIOCGIWSCAN events to notify