From patchwork Tue Feb 20 13:18:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Berg X-Patchwork-Id: 1901474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xFYPzmj8; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=CBL1uldF; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TfKkf0BYSz23cy for ; Wed, 21 Feb 2024 00:19:38 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DvFHV457MC0K2hfIGc23nkEIR4we+6aERJPCLgDM5JQ=; b=xFYPzmj8NqgChE vWmnw+3NkEZMjA2xbYqxBU7h2o88odBN4efHMOs5kDBVx2+7aWFEV2c8OU5v5zWMyThwzzw9OqnEs ThnU9XRlQ3Dqs0nFEN5wbxgpeLg7cKFvVLBq9nkkc7jmj0VkvAkrGHE+ACXH3Z1CsZkQPjP2Qfg2o yzZdxmF1jGOPuy47m3KxRngy8DEfS1b3/xINvbPHsz/4ZaptjyunUacN9W1CBIJ+1F9WxMrofmhGB LBOmdN4Z91IIEUAZM/gqhD7CMzodRXPcorUCK9UB69AKhmnircsRlbXr+jzWZ1R8QLbeqmyGaNOwh qZRk8MF0SpG65BJoil5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcQ1r-0000000EpEO-0rcE; Tue, 20 Feb 2024 13:19:23 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcQ1a-0000000Ep3V-1mAO for hostap@lists.infradead.org; Tue, 20 Feb 2024 13:19:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=7Ok6Lie8t6uPA5xi44X24e3b2hQR7uVH7lZjfkN6DKY=; t=1708435146; x=1709644746; b=CBL1uldFcRjOttr0wth3SwJC673HK1Xc1eW/31UCtz5gZp9 pt196og9uee0DM06gOPZ8tCGlSs8XTOERFBpkgVWspQhRBX0R5XKR9B9W+GM1TUGoMXwNr3VaF35u GMTaKB9X2HkQjnasX8JEoCACb12q/XTBNeookXzkPUTWQjUDeuNRp+Ai3qmXTzXKlJPEjUp8Girjc WYgv4yM1fBb9DgGPH/eQ9Q6x4MJFvgk0ps4QOz6mBan5snC0ezWifOGPxtKOEdDNDkRekiLs3gO0E jUkg0pDDqFTpSfutcbWg6Kq1gIqK5e9z1xBXLBEd/9uiQGr9W83uFOUzk/a5wUVA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rcQ1Y-00000000ugq-2hU0; Tue, 20 Feb 2024 14:19:04 +0100 From: benjamin@sipsolutions.net To: hostap@lists.infradead.org Cc: Benjamin Berg Subject: [PATCH v2 10/20] WNM: Don't scan frequencies of neighbors that should be ignored Date: Tue, 20 Feb 2024 14:18:17 +0100 Message-ID: <20240220131827.17766-11-benjamin@sipsolutions.net> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240220131827.17766-1-benjamin@sipsolutions.net> References: <20240220131827.17766-1-benjamin@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_051906_547870_16D1750F X-CRM114-Status: GOOD ( 10.20 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Benjamin Berg It does not make sense to scan for neighbors that we are not supposed to use anyway. As such, skip them. Signed-off-by: Benjamin Berg --- wpa_supplicant/wnm_sta.c | 4 ++++ 1 file changed, 4 insertions(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Benjamin Berg It does not make sense to scan for neighbors that we are not supposed to use anyway. As such, skip them. Signed-off-by: Benjamin Berg --- wpa_supplicant/wnm_sta.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/wpa_supplicant/wnm_sta.c b/wpa_supplicant/wnm_sta.c index 6f5f63a8d..71608a394 100644 --- a/wpa_supplicant/wnm_sta.c +++ b/wpa_supplicant/wnm_sta.c @@ -1356,6 +1356,10 @@ static void wnm_set_scan_freqs(struct wpa_supplicant *wpa_s) struct neighbor_report *nei; nei = &wpa_s->wnm_neighbor_report_elements[i]; + + if (nei->preference_present && nei->preference == 0) + continue; + if (nei->freq <= 0) { wpa_printf(MSG_DEBUG, "WNM: Unknown neighbor operating frequency for "