diff mbox series

[49/50] tests: Remove dynamically added hostapd interfaces

Message ID	20230215230904.933291-50-andrei.otcheretianski@intel.com
State	Accepted
Headers	show Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Andrei Otcheretianski <andrei.otcheretianski@intel.com> To: hostap@lists.infradead.org Cc: Avraham Stern <avraham.stern@intel.com> Subject: [PATCH 49/50] tests: Remove dynamically added hostapd interfaces Date: Thu, 16 Feb 2023 01:09:03 +0200 Message-Id: <20230215230904.933291-50-andrei.otcheretianski@intel.com> In-Reply-To: <20230215230904.933291-1-andrei.otcheretianski@intel.com> References: <20230215230904.933291-1-andrei.otcheretianski@intel.com> MIME-Version: 1.0 preview: From: Avraham Stern <avraham.stern@intel.com> When an in interface is added dynamically to hostapd with HWSimRadio, it's not removed during device reset. This requires to manually remove it, otherwise subsequent tests may fail. Better do it durin [...] Content analysis details: (-2.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [134.134.136.65 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Add basic MLO support for AP \| expand [00/50] Add basic MLO support for AP [01/50] nl80211: Refactor i802_bss to support multiple links [02/50] driver_nl80211: Introduce and implement a callback to add MLO link [03/50] driver: Add MLD link id to AP parameters [04/50] driver: Allow to provide a link ID when setting a channel [05/50] driver_nl80211: Provide link_id in EAPOL_RX and RX_MGMT events [06/50] driver_nl80211: Support setting up an AP on a specified link [07/50] driver_nl80211: Properly stop and deinit MLO AP [08/50] AP: Add some basic MLD configuration options [09/50] AP: Allow starting multiple interfaces within single MLD [10/50] AP: Include an RNR element in beacons for MLD AP [11/50] driver_nl80211: Select freq according to transmitting link [12/50] nl80211: Support adding multi link stations [13/50] common: Split ieee8021_parse_elems() [14/50] common: Add support for clearing elements [15/50] common: Support parsing link specific association request [16/50] AP: Split check_assoc_ies() [17/50] AP: MLO: Make 802.1X SM, authserv and radius client singletons [18/50] AP: Match Rx frames against MLD address [19/50] AP: Support building basic Multi-Link Element [20/50] AP: MLO: Handle ML element during authentication [21/50] AP: MLO: Add MLO information to hostapd_sta_add_params struct [22/50] AP: MLO: Process EHT ML element from association request [23/50] AP: MLO: Add ML element to association response [24/50] AP: MLO: Handle association callback [25/50] AP: MLO: Handle deauth/disassoc of MLD station [26/50] AP: MLO: Handle 802.1X port authorization [27/50] driver: Specify link ID for 'send_mlme' and 'sta_deauth' callbacks [28/50] AP: Do not prune station when adding a link station [29/50] AP: Handle TX status for MLD AP [30/50] AP: Print MLD info in STATUS command [31/50] AP/wpa_supplicant/driver: Add link id to send eapol callbacks [32/50] AP: Provide the link ID for an MLD setting when setting VLAN [33/50] AP/driver: Add link id to the set_tx_queue_params() callback [34/50] driver_nl80211: use frequency to determine mld link for MLME events [35/50] AP: Forward link specific events [36/50] WPA_AUTH: MLO: Add functions to get the AA and SPA [37/50] WPA_AUTH: MLO: Store MLO link information [38/50] WPA_AUTH: MLO: Add MAC KDE to 1st message in 4-way handshake [39/50] WPA_AUTH: MLO: Validate MLO KDEs in 2nd message of 4-way handshake [40/50] WPA_AUTH: MLO: Add MLO KDEs to message 3 of the 4-way handshake [41/50] WPA_AUTH: MLO: Validate MLO KDEs in 4th message of 4-way handshake [42/50] WPA_AUTH: MLO: Add MLO KDEs to message 1 of the group handshake [43/50] WPA_AUTH: MLO: Get the correct AA and SPA based on MLD operation [44/50] AP: Specify the link ID for set_key() callback [45/50] AP: Use MLD address for SAE commit derivation [46/50] AP: Don't process SAE/OWE assoc info on MLD links [47/50] AP: Use MLD address for traffic tests [48/50] tests: Clear sae_groups in eht_sae test [49/50] tests: Remove dynamically added hostapd interfaces [50/50] tests: Add basic MLD hwsim tests

Commit Message

Andrei Otcheretianski Feb. 15, 2023, 11:09 p.m. UTC

From: Avraham Stern <avraham.stern@intel.com>

When an in interface is added dynamically to hostapd with
HWSimRadio, it's not removed during device reset.
This requires to manually remove it, otherwise subsequent tests may
fail. Better do it during device reset.

Signed-off-by: Avraham Stern <avraham.stern@intel.com>
---
 tests/hwsim/run-tests.py | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff mbox series

Patch

diff --git a/tests/hwsim/run-tests.py b/tests/hwsim/run-tests.py
index 0784575f28..f63bb56776 100755
--- a/tests/hwsim/run-tests.py
+++ b/tests/hwsim/run-tests.py
@@ -69,13 +69,10 @@  def reset_devs(dev, apdev):
     try:
         hapd = HostapdGlobal()
         hapd.flush()
-        hapd.remove('wlan3-6')
-        hapd.remove('wlan3-5')
-        hapd.remove('wlan3-4')
-        hapd.remove('wlan3-3')
-        hapd.remove('wlan3-2')
-        for ap in apdev:
-            hapd.remove(ap['ifname'])
+        ifaces = hapd.request("INTERFACES").splitlines()
+        for iface in ifaces:
+            if iface.startswith("wlan"):
+                hapd.remove(iface)
         hapd.remove('as-erp')
     except Exception as e:
         logger.info("Failed to remove hostapd interface")