[12/50] nl80211: Support adding multi link stations

Message ID	20230215230904.933291-13-andrei.otcheretianski@intel.com
State	Accepted
Headers	show Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Andrei Otcheretianski <andrei.otcheretianski@intel.com> To: hostap@lists.infradead.org Cc: Andrei Otcheretianski <andrei.otcheretianski@intel.com> Subject: [PATCH 12/50] nl80211: Support adding multi link stations Date: Thu, 16 Feb 2023 01:08:26 +0200 Message-Id: <20230215230904.933291-13-andrei.otcheretianski@intel.com> In-Reply-To: <20230215230904.933291-1-andrei.otcheretianski@intel.com> References: <20230215230904.933291-1-andrei.otcheretianski@intel.com> MIME-Version: 1.0 preview: Multi link stations are represented in the kernel using a single station with multiple links and the first ADD_STA command also creates the first link. Subsequent links should be added with LINK_ADD c [...] Content analysis details: (-2.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [134.134.136.65 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Add basic MLO support for AP \| expand [00/50] Add basic MLO support for AP [01/50] nl80211: Refactor i802_bss to support multiple links [02/50] driver_nl80211: Introduce and implement a callback to add MLO link [03/50] driver: Add MLD link id to AP parameters [04/50] driver: Allow to provide a link ID when setting a channel [05/50] driver_nl80211: Provide link_id in EAPOL_RX and RX_MGMT events [06/50] driver_nl80211: Support setting up an AP on a specified link [07/50] driver_nl80211: Properly stop and deinit MLO AP [08/50] AP: Add some basic MLD configuration options [09/50] AP: Allow starting multiple interfaces within single MLD [10/50] AP: Include an RNR element in beacons for MLD AP [11/50] driver_nl80211: Select freq according to transmitting link [12/50] nl80211: Support adding multi link stations [13/50] common: Split ieee8021_parse_elems() [14/50] common: Add support for clearing elements [15/50] common: Support parsing link specific association request [16/50] AP: Split check_assoc_ies() [17/50] AP: MLO: Make 802.1X SM, authserv and radius client singletons [18/50] AP: Match Rx frames against MLD address [19/50] AP: Support building basic Multi-Link Element [20/50] AP: MLO: Handle ML element during authentication [21/50] AP: MLO: Add MLO information to hostapd_sta_add_params struct [22/50] AP: MLO: Process EHT ML element from association request [23/50] AP: MLO: Add ML element to association response [24/50] AP: MLO: Handle association callback [25/50] AP: MLO: Handle deauth/disassoc of MLD station [26/50] AP: MLO: Handle 802.1X port authorization [27/50] driver: Specify link ID for 'send_mlme' and 'sta_deauth' callbacks [28/50] AP: Do not prune station when adding a link station [29/50] AP: Handle TX status for MLD AP [30/50] AP: Print MLD info in STATUS command [31/50] AP/wpa_supplicant/driver: Add link id to send eapol callbacks [32/50] AP: Provide the link ID for an MLD setting when setting VLAN [33/50] AP/driver: Add link id to the set_tx_queue_params() callback [34/50] driver_nl80211: use frequency to determine mld link for MLME events [35/50] AP: Forward link specific events [36/50] WPA_AUTH: MLO: Add functions to get the AA and SPA [37/50] WPA_AUTH: MLO: Store MLO link information [38/50] WPA_AUTH: MLO: Add MAC KDE to 1st message in 4-way handshake [39/50] WPA_AUTH: MLO: Validate MLO KDEs in 2nd message of 4-way handshake [40/50] WPA_AUTH: MLO: Add MLO KDEs to message 3 of the 4-way handshake [41/50] WPA_AUTH: MLO: Validate MLO KDEs in 4th message of 4-way handshake [42/50] WPA_AUTH: MLO: Add MLO KDEs to message 1 of the group handshake [43/50] WPA_AUTH: MLO: Get the correct AA and SPA based on MLD operation [44/50] AP: Specify the link ID for set_key() callback [45/50] AP: Use MLD address for SAE commit derivation [46/50] AP: Don't process SAE/OWE assoc info on MLD links [47/50] AP: Use MLD address for traffic tests [48/50] tests: Clear sae_groups in eht_sae test [49/50] tests: Remove dynamically added hostapd interfaces [50/50] tests: Add basic MLD hwsim tests

Message ID

20230215230904.933291-13-andrei.otcheretianski@intel.com

State

Accepted

Headers

From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
To: hostap@lists.infradead.org
Cc: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Subject: [PATCH 12/50] nl80211: Support adding multi link stations
Date: Thu, 16 Feb 2023 01:08:26 +0200
Message-Id: <20230215230904.933291-13-andrei.otcheretianski@intel.com>
In-Reply-To: <20230215230904.933291-1-andrei.otcheretianski@intel.com>
References: <20230215230904.933291-1-andrei.otcheretianski@intel.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Hostap" <hostap-bounces@lists.infradead.org>
Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Add basic MLO support for AP | expand

Commit Message

Andrei Otcheretianski Feb. 15, 2023, 11:08 p.m. UTC

Multi link stations are represented in the kernel using a single
station with multiple links and the first ADD_STA command also
creates the first link. Subsequent links should be added with
LINK_ADD commands.

Implement this logic and provide the required MLD information per
station/link.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
---
 src/ap/ap_drv_ops.c          |  1 +
 src/drivers/driver.h         |  4 +++
 src/drivers/driver_nl80211.c | 59 +++++++++++++++++++++++++++++++-----
 wpa_supplicant/driver_i.h    |  5 ++-
 4 files changed, 61 insertions(+), 8 deletions(-)

diff --git a/src/ap/ap_drv_ops.c b/src/ap/ap_drv_ops.c
index bd2cf7cea5..cd509c90a9 100644
--- a/src/ap/ap_drv_ops.c
+++ b/src/ap/ap_drv_ops.c
@@ -459,6 +459,7 @@  int hostapd_sta_add(struct hostapd_data *hapd,
 	params.qosinfo = qosinfo;
 	params.support_p2p_ps = supp_p2p_ps;
 	params.set = set;
+	params.mld_link_id = -1;
 	return hapd->driver->sta_add(hapd->drv_priv, &params);
 }
 
diff --git a/src/drivers/driver.h b/src/drivers/driver.h
index 0f225929ab..38722f5db4 100644
--- a/src/drivers/driver.h
+++ b/src/drivers/driver.h
@@ -2416,6 +2416,10 @@  struct hostapd_sta_add_params {
 	const u8 *supp_oper_classes;
 	size_t supp_oper_classes_len;
 	int support_p2p_ps;
+
+	bool mld_link_sta;
+	s8 mld_link_id;
+	const u8 *mld_link_addr;
 };
 
 struct mac_address {
diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 456556e100..0987f11677 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -5385,16 +5385,29 @@  static int wpa_driver_nl80211_sta_add(void *priv,
 	struct nl_msg *msg;
 	struct nl80211_sta_flag_update upd;
 	int ret = -ENOBUFS;
+	u8 cmd;
+	const char *cmd_string;
 
 	if ((params->flags & WPA_STA_TDLS_PEER) &&
 	    !(drv->capa.flags & WPA_DRIVER_FLAGS_TDLS_SUPPORT))
 		return -EOPNOTSUPP;
 
+	if (params->mld_link_sta) {
+		cmd = params->set ? NL80211_CMD_MODIFY_LINK_STA :
+				    NL80211_CMD_ADD_LINK_STA;
+		cmd_string = params->set ? "NL80211_CMD_MODIFY_LINK_STA" :
+					   "NL80211_CMD_ADD_LINK_STA";
+	} else {
+		cmd = params->set ? NL80211_CMD_SET_STATION :
+				    NL80211_CMD_NEW_STATION;
+		cmd_string = params->set ? "NL80211_CMD_SET_STATION" :
+					   "NL80211_CMD_NEW_STATION";
+	}
+
 	wpa_printf(MSG_DEBUG, "nl80211: %s STA " MACSTR,
-		   params->set ? "Set" : "Add", MAC2STR(params->addr));
-	msg = nl80211_bss_msg(bss, 0, params->set ? NL80211_CMD_SET_STATION :
-			      NL80211_CMD_NEW_STATION);
-	if (!msg || nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, params->addr))
+		   cmd_string, MAC2STR(params->addr));
+	msg = nl80211_bss_msg(bss, 0, cmd);
+	if (!msg)
 		goto fail;
 
 	/*
@@ -5612,12 +5625,44 @@  static int wpa_driver_nl80211_sta_add(void *priv,
 		nla_nest_end(msg, wme);
 	}
 
+	/* In case the AP is an MLD AP need to always specify the link ID */
+	if (params->mld_link_id >= 0) {
+		wpa_printf(MSG_DEBUG, "  * mld_link_id=%d",
+			   params->mld_link_id);
+		if (nla_put_u8(msg, NL80211_ATTR_MLO_LINK_ID,
+			       params->mld_link_id))
+			goto fail;
+
+		/*
+		 * If the link address is specified the station is a non MLD AP
+		 * station and thus need to provide the MLD address as the
+		 * station address, and the non MLD AP link address as the link
+		 * address
+		 */
+		if (params->mld_link_addr) {
+			wpa_printf(MSG_DEBUG, "  * mld_link_addr=" MACSTR,
+				   MAC2STR(params->mld_link_addr));
+
+			if (nla_put(msg, NL80211_ATTR_MLD_ADDR,
+				    ETH_ALEN, params->addr) ||
+			    nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN,
+				    params->mld_link_addr))
+				goto fail;
+		} else {
+			if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN,
+				    params->addr))
+				goto fail;
+		}
+	} else {
+		if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, params->addr))
+			goto fail;
+	}
+
 	ret = send_and_recv_msgs(drv, msg, NULL, NULL, NULL, NULL);
 	msg = NULL;
 	if (ret)
-		wpa_printf(MSG_DEBUG, "nl80211: NL80211_CMD_%s_STATION "
-			   "result: %d (%s)", params->set ? "SET" : "NEW", ret,
-			   strerror(-ret));
+		wpa_printf(MSG_DEBUG, "nl80211: %s result: %d (%s)",
+			   cmd_string, ret, strerror(-ret));
 	if (ret == -EEXIST)
 		ret = 0;
 fail:
diff --git a/wpa_supplicant/driver_i.h b/wpa_supplicant/driver_i.h
index 7fc9b270a8..dd9858d59e 100644
--- a/wpa_supplicant/driver_i.h
+++ b/wpa_supplicant/driver_i.h
@@ -353,8 +353,11 @@  static inline int wpa_drv_set_ap(struct wpa_supplicant *wpa_s,
 static inline int wpa_drv_sta_add(struct wpa_supplicant *wpa_s,
 				  struct hostapd_sta_add_params *params)
 {
-	if (wpa_s->driver->sta_add)
+	if (wpa_s->driver->sta_add) {
+		/* Set link_id to -1 as it's needed for AP only */
+		params->mld_link_id = -1;
 		return wpa_s->driver->sta_add(wpa_s->drv_priv, params);
+	}
 	return -1;
 }

[12/50] nl80211: Support adding multi link stations

Commit Message

Patch