From patchwork Thu Jul 14 16:53:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Savchenko X-Patchwork-Id: 1656557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=AfhEK9SZ; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=celeno.com header.i=@celeno.com header.a=rsa-sha256 header.s=selector2 header.b=gKR7f67k; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LkLFt4wFmz9sGR for ; Fri, 15 Jul 2022 02:55:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ekzmXYZPJgaQupB1IDr8grT65rwnNCcv6VQAPRcemRU=; b=AfhEK9SZfFeVN/ dcRl05GLxP16gAziNYzwxDBeZyOdiLmkC4bh0pPuluCIKUbmYcihNmI6LuuseGAPKCbS6CXgMZZvz 0ykbzU01HLNn6NkIH3+QA5KTDS9waoxvxTmMe+hi5Gv6XM2YqmiEi1DpiG2mZ5k7NMEnrAYKEA3c2 K9UWs2FLNk08okr6QLkrqg7qO4ha/6vaCsBb9Sc4knuNjPVQ3lZYUhHDDuIQzYKI1/usc2vqxnZyP Ggwl4aoiXhx0eQY1SdEK5YpK9ggFvq/WUJ0owv+Zmhl0lUm2G8xi4VSh4hIWs6DtYp8nByajopANf ZSaE38w/7cEFs9f2EDGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC26F-00GRuc-Eb; Thu, 14 Jul 2022 16:54:03 +0000 Received: from mail-eopbgr150041.outbound.protection.outlook.com ([40.107.15.41] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC25l-00GRnP-C3 for hostap@lists.infradead.org; Thu, 14 Jul 2022 16:53:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQIdADE45s1zkBlZ5qA2SgJnBKTDUfQHTEnc02jtDMDssxuJA9S3ev/XCZYBVp1QGdw9deAq2ugKKlZ5M9oljo8Fw8p9yYjXtdlET8iYzyNRMapwmnIyfPsgOg1s70oYR9+22GXBAZJz7cuIGKkfsgD9sGFnnnF6ldmMWpgZ2nUKS+mAjEiqRgLgm+eFRgaO+3nJ9KkhUvwFq7YtpZm5o4+lbTnsmguzF1CqM1730znY2ZYrr/+zPmYno2759WaUjzw4DniTfoqSz5NUch6WLJxZ0CpFapTuUpGWsbDVe1Bzri5Uc/pgMdNAw8RCy1JbS/AvNZcFHS2dzJePlJyx+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZdmA9ScQc3iU4cYz6EmGq7jIqSOW/onfY6cmx7mOWUQ=; b=J83H2HW89cS/Yd/r0cH8sHPCzAXhcraaSBEVjVT25LOJEOs0s1VGYsNbebo4a7hWmXCn1tFSH40UyfMtW9+lx2vD//66/V9TMohsD3qrFgezuRgpGd8F49atQWNP7Mx2mVVf+52n8j5fAD1gw6/2AlP3kghnepFRINQVdIZMd2vFlQlzLO1d8mtVlH83QGFuIYDeW1NiXsA1rJ8aItLus8trT91BguL+cdCWLubraVGWEZsKOjXIV/O8Ruw9vA7hHindjakWDPXSuQ79DvODwrmSkljS6hqVU5Ll/T+TX6MLKde4nAPmUjLwJJJsMBebWeA18nGnFpFwK4XUgsE0mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=celeno.com; dmarc=pass action=none header.from=celeno.com; dkim=pass header.d=celeno.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=celeno.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZdmA9ScQc3iU4cYz6EmGq7jIqSOW/onfY6cmx7mOWUQ=; b=gKR7f67k41s8yAWB4HIPd7PuYDRF4vTUdCzF1JCPK0U05/6+BymStuBDKohl+4nD8BZeXVEdwHDmyE9MqN4q6UNz0hqVGmyZf2fFTd3R1jxJr9l76P6z25L9llWzDLqouw/hsytJXWism+Xy+IGdYiV/8CamBUNJ90l8yjuT7yc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=celeno.com; Received: from AS4P192MB1552.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:4b7::6) by DB9P192MB1323.EURP192.PROD.OUTLOOK.COM (2603:10a6:10:299::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Thu, 14 Jul 2022 16:53:19 +0000 Received: from AS4P192MB1552.EURP192.PROD.OUTLOOK.COM ([fe80::c071:8de4:b884:dc7b]) by AS4P192MB1552.EURP192.PROD.OUTLOOK.COM ([fe80::c071:8de4:b884:dc7b%9]) with mapi id 15.20.5438.012; Thu, 14 Jul 2022 16:53:19 +0000 From: oleksandr.savchenko@celeno.com To: hostap@lists.infradead.org Cc: Jouni Malinen , Johannes Berg , Viktor Barna , Sergiy Petrov , Alexander Savchenko Subject: [PATCH v1 2/6] Revert "nl80211: Indicate interface-down event only for the main netdev" Date: Thu, 14 Jul 2022 19:53:02 +0300 Message-Id: <20220714165306.2938319-3-oleksandr.savchenko@celeno.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20220714165306.2938319-1-oleksandr.savchenko@celeno.com> References: <20220714165306.2938319-1-oleksandr.savchenko@celeno.com> X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To AS4P192MB1552.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:4b7::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae0975a5-64ed-4b06-9f55-08da65b95acd X-MS-TrafficTypeDiagnostic: DB9P192MB1323:EE_ X-LD-Processed: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZbCoJpfAg/CrSMn/6Ft5aIoo8bCQymt88/HgPaVKlY0/SCQ43kVwFuJmMuFnOFmKE3LfKr5CGEJf2MNLLXYHzF9pOJQlUz0qRLQnlwmmydsjwdNeotTFHVU19C+gy4nBba3icEy9td4n/GIlV1FTyONcWwXYNt8PKZCvBomyXDCcMkLIfthDJIGi5cUyTJBM+tTG3YGSw/McEWxVvA4CSqb2RwTJU6ZD2rOK1Hb9Aww5VALsA3mcdNaiT3OMJmfgCPYwGC0sz/CoQ5iu5Js7D86ifSHkE8W3pRAIVrsEOJw9Cx7JPA7l7fT/UHCBbsA9V3YgWqNuImIOanCMiok+1F4AOnKD+yxSJAoDpHVOgQqvd1D0tvJaFbbRMff1J9wpaZ/G/GlZdpGOz1kOy3WlVO6/2MMe5ALUR5hFkPEbKD5mhsjjEvlIrMe20YZEswezoxcGr0UM36BjrhfUcC3QiuYRO9HRbkqBJBsUjUwbNXcis9McFHduKKYFqLWsatFPdKqfMQ8VYqEKOqpseVm/w56Tj5tS4uBnHSue/lXoDT4GOx/PDBmvDuRE9qAWlXHx91uxLr9k4m7uca7UiUqORXA9uMDP3edySuPauNB2+GvBA2nZGY6E+SJmoMOFzi9pd0OgYfZaw0il5N+pRynVjudXw0sVVLHUztAJ4mLTIRRqDCXB69r3VKs2+lKLBG7hxp1Fa6LpYEcojU/DGcz28KvA1cBoH0fJei5KdjUl7TsXUXg55k6ke9JoPZi41F85Sa2cdalbV2uukAvcY12LmXoj/N81LRfGZ57uJI8zSSSX9YDxhvOBB/YMEkxo/oHo X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4P192MB1552.EURP192.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(346002)(39850400004)(396003)(366004)(66556008)(6666004)(478600001)(26005)(6916009)(2906002)(66946007)(4326008)(41300700001)(316002)(9686003)(6506007)(8676002)(6512007)(36756003)(52116002)(86362001)(54906003)(66476007)(6486002)(8936002)(186003)(38100700002)(2616005)(38350700002)(1076003)(107886003)(5660300002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4VeDonqpeeBpPZ0Zi/qzdx5FOVIdpac2M0pQcfQw40iiXbXsEPPlFbjAPL1FEk1q3TmdX1pkdn+7UlqiT69T41QrwmAJ8KQvNL332d+Z44xlH8ioGMTD0D9uMv2NT/GlH8E322HMx/SqMu14RSv4S0FptiMyzdyejj+u2YTOzhO8Orvm9T6Ir59goCJaQLEn4XbUX+Upyter7CkIkC3/LHt3BrCZxUWIR4ebXVhD6p+wezEoGG1M1jqz9l/f0crbEIXT2Uiq/866EYVvV8jBq9rOzW5yIfHOTywSdeTLLGYaom0Mwsel2q4Xzn/u4ahleZrJGFoFuswYAgwMlMCVPE2Ye7JMPEUH7zsMtisikf6E8G5XKIRyRvJmWahI2gx7vDa9dNYPh10OiiTpyxcM+3Uw8ZuwY+aKQcSgOEtF/EJg7Hq2WwWbbtqr8/z8D3UDcIXcy6j8O8yvkk5MiTNXtiDXMPOF3rHOmcjXtdWItrubHYWd01NDT764IXYZnJAfj4EVB9MS/3f0sf+YCt5bpZg6ERiC2C4iAys2FCyFs1ZhcRHUilN3ptJvgT9B4ysJOabW8VHu4z4VXgdARPDaxQlul/t48upitvsNpKonyIBCZl36d6PxNxQvbJVYxTc6yIfwlyipElCkztvBvV1Kf/ApMzT13nH/Zy2MaGZuq2PW/5lpjvsKVcV97Pfr6FzPKMPi9BBFHOQU1eH51dWnSeaW00xqUTk/CPAxECMwInGo1j5p/2WipfsBEi3htTIQnskEId2P/mqkb3RbavnkNDrutGbQ1PDHI2qQzqW2kIRxFw0T8D7vlM/ObD3twwlRoJiXvACIqMFRHvdp1vKTmwKWBknnzthJlWlFsEvLq7QhbWSuSa8/mkEBh3TkrtPMwaBFCXQRMWofIIi4D4Wv7/rGF32hDm1msTwyJCghBwv7/JExAMZCmGn81FM6e0DYtH2sJptRE33MBK1Lu9OXgyoVbJG0eQLfFoUORCrcDma2ULAITNipAr04RSW+97ymJPG9494YIssuEtEM5ZrMFg9MJxxDxz+9SsPkEuAn88XQSwLHYNkqShp7wj8b1Ht2EK7oY9CgXBD/Wy8i8oedKG+F/VgRa2hE57Hc3RiUPwpjdkJcGRD+pHC7hmbo5fvD8ydR/G1zlVu4qarEiXmiT/UEB6nvISFVp4XpPNDrPH+41cHxa66iLLXpqwWX6cLWbZaX5JzpDihX7q7nWEu5JZASd6qFzMIvzy5obR1vRybV6sFp/J3i6PgKNhrV72KkJOdOgBh3DhpspJt1ORW93yVCQW5fPuS1mx97lIdjoj5OLVBAyyK/un0QlEBTNgwuVFetxrWZvZ0sXVwvAKCCTKgkU7eYk/stuSRPnlq+FU5MUjNpZj6Ejt+MLno4STh5BnzJg3G6mbZ7xMslfz+eCbN1sS3mVDl9spGtM1Oyro+NvoSoF007W+yMEErT6QlZb7SYkZFEv6hv3dptMXLFzBuscmUpxhKAFi4c+0uN6opGksv8hopdhTlr0LihbkUNO9xcPjl7m6VN4pvjRHAx65lZZPlyXCLdOMmjfGASDMcZ4JmUtos8uvi+gAvoPMTmbNXXArmIHb6z+Qvy7ayUwg== X-OriginatorOrg: celeno.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae0975a5-64ed-4b06-9f55-08da65b95acd X-MS-Exchange-CrossTenant-AuthSource: AS4P192MB1552.EURP192.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 16:53:19.4219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fyatE1rBNopqdm7ykXzb9zQJtPRlYah70RCeMuzreFpmJOvub5sUxsVJXd2zLkE/0Kwr064wYrj6VcNvLSRvQrNdFxXTOdPYTYRQDZZKAo8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P192MB1323 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_095333_434254_A5600122 X-CRM114-Status: GOOD ( 10.80 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Alexander Savchenko This reverts commit 106fa1e97e29e7514ae324020802c280f993ee48. Commit 106fa1e97 breaks the virtual AP mode due to non-main interfaces can't receive DOWN state. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.15.41 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.15.41 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Alexander Savchenko This reverts commit 106fa1e97e29e7514ae324020802c280f993ee48. Commit 106fa1e97 breaks the virtual AP mode due to non-main interfaces can't receive DOWN state. Signed-off-by: Alexander Savchenko --- src/drivers/driver_nl80211.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 158700f65..a9fe3e36d 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -1237,9 +1237,9 @@ static void wpa_driver_nl80211_event_rtm_newlink(void *ctx, return; /* do not update interface state */ if (!drv->if_disabled && !(ifi->ifi_flags & IFF_UP)) { - namebuf[0] = '\0'; if (if_indextoname(ifi->ifi_index, namebuf) && - linux_iface_up(drv->global->ioctl_sock, namebuf) > 0) { + linux_iface_up(drv->global->ioctl_sock, + drv->first_bss->ifname) > 0) { wpa_printf(MSG_DEBUG, "nl80211: Ignore interface down " "event since interface %s is up", namebuf); drv->ignore_if_down_event = 0; @@ -1247,13 +1247,8 @@ static void wpa_driver_nl80211_event_rtm_newlink(void *ctx, nl80211_refresh_mac(drv, ifi->ifi_index, 1); return; } - wpa_printf(MSG_DEBUG, "nl80211: Interface down (%s/%s)", - namebuf, ifname); - if (os_strcmp(drv->first_bss->ifname, ifname) != 0) { - wpa_printf(MSG_DEBUG, - "nl80211: Not the main interface (%s) - do not indicate interface down", - drv->first_bss->ifname); - } else if (drv->ignore_if_down_event) { + wpa_printf(MSG_DEBUG, "nl80211: Interface down"); + if (drv->ignore_if_down_event) { wpa_printf(MSG_DEBUG, "nl80211: Ignore interface down " "event generated by mode change"); drv->ignore_if_down_event = 0; @@ -1276,7 +1271,8 @@ static void wpa_driver_nl80211_event_rtm_newlink(void *ctx, if (drv->if_disabled && (ifi->ifi_flags & IFF_UP)) { if (if_indextoname(ifi->ifi_index, namebuf) && - linux_iface_up(drv->global->ioctl_sock, namebuf) == 0) { + linux_iface_up(drv->global->ioctl_sock, + drv->first_bss->ifname) == 0) { wpa_printf(MSG_DEBUG, "nl80211: Ignore interface up " "event since interface %s is down", namebuf);