From patchwork Fri Jul 16 05:21:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arowa Suliman X-Patchwork-Id: 1506000 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=RRaBeP5t; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=bDBtXop6; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GR04B3b10z9sWq for ; Fri, 16 Jul 2021 15:22:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S59jSA5vBTB1zcZo1p2S9sDNuDMvjcJh0hRh//Rn2PY=; b=RRaBeP5t1UkVOI /tWabXuhmgBV+jV33uiQ7XMApschHJJqHE5rLdajP5891MzwBUvpPLlNDAJXR4f5WlX3EPhynjPVT RbJwjcfGFHL8s4u+2Q2PNBzWFx06EwTW6XMtGTNvcyJ41jDHIDws2E1VaL8C4x0rYNVGIVMx6SZ65 QKOOtPxIm6pifWytNo2aRAWUnGor6Y7wGttcPS69mOjAha9SgGFbMqiPWodWeROmN0z47B3K840ym 6/kux5QZBcumFOIvlbaJlZa2AHcQ0BRRfkOSXg1/xaweDse/JLEjG/hOmJec3PshkdP8FNvDic42y xEf2VUJMP1fmRBYHuluA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4GI5-003AO5-9f; Fri, 16 Jul 2021 05:21:37 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4GHy-003ALD-Q2 for hostap@lists.infradead.org; Fri, 16 Jul 2021 05:21:32 +0000 Received: by mail-pl1-x631.google.com with SMTP id b12so4737644plh.10 for ; Thu, 15 Jul 2021 22:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rQFG5KBH8r1uSOY1VX99PUU59RmP/+gVvgMDBWA8yGE=; b=bDBtXop6MdcsuylPAlYZVy7bppBTDZl2UPRkjLi0JkEmnvQ/qGOJH8mOz6/KIKCTVB cPiiZn3CwhCauIvSLTmiYott8InG5Bj9/KduLpGfQcZh6C1sktm06tekCR6pk1j8Ym/M +zE0iI5piKVrfnyHc/Z0P5gSzxfRqSGkcyanA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rQFG5KBH8r1uSOY1VX99PUU59RmP/+gVvgMDBWA8yGE=; b=OqGGGqiXKzIOmfmS6CHue5yZViRak0VqDsYxvDDeFCtUkh7ANbW2OUa77WfWOEnpNH i2/zom32zoHXRiahTJRK5o4ZIgVLiD1bvFVpKe8T03W88iRuPpGHMcGDTVZNeiThRGy5 SM1gGRdRgB+oF/n+gGLuU0FSD4ppmsnuPeGUzauUCbGjCeJ1uWOZQdDetQ4ldSwN7ayZ RgscB1vLmJV8Q35UBvJV1aMrFxlHMHMG5/tdHPcQzq4CQXZJ1c+zrZ/CNW3VMb7oWgo8 aJdxf5hMtQAmKjOoCjEe91Pf/AYKeuZO0gZ/5AsQRlIY//DJUhbZA9xz4x/4Ewco4QAJ ZgVg== X-Gm-Message-State: AOAM531kHVzsI+NWNF9QE0TFXAZWEhEVWld2rLQ3DXxptWOXm5veJh1a +HFdFCeD79Xt54qCANvkCztpj1MSKcJX+A== X-Google-Smtp-Source: ABdhPJzgLg+ORqPdV3Rp4PjoGvgXyGFzvfLs8uKpVx/Ekk5lMbOCAYM7gjFBgRWqVcFeVOK/Kf4CdA== X-Received: by 2002:a17:902:6b09:b029:129:c61e:e31a with SMTP id o9-20020a1709026b09b0290129c61ee31amr6328599plk.57.1626412889988; Thu, 15 Jul 2021 22:21:29 -0700 (PDT) Received: from arowa.mtv.corp.google.com ([2620:15c:202:201:9ee6:32bb:8e18:c20a]) by smtp.gmail.com with ESMTPSA id u19sm8456934pfi.4.2021.07.15.22.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 22:21:29 -0700 (PDT) From: Arowa Suliman X-Google-Original-From: Arowa Suliman To: hostap@lists.infradead.org Cc: Arowa Suliman , Arowa Suliman Subject: [PATCH v4 2/8] wpa_supplicant: src: Replace Sane with Valid. Date: Thu, 15 Jul 2021 22:21:05 -0700 Message-Id: <20210716052110.2714866-2-arowa@google.com> X-Mailer: git-send-email 2.32.0.402.g57bb445576-goog In-Reply-To: <20210716052110.2714866-1-arowa@google.com> References: <20210716052110.2714866-1-arowa@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_222130_932664_18687326 X-CRM114-Status: GOOD ( 16.97 ) X-Spam-Score: -0.4 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Replace the word Sane with Valid which is inclusive. Signed-off-by: Arowa Suliman --- src/drivers/driver.h | 4 ++-- src/drivers/driver_common.c | 2 +- src/drivers/driver_nl80211_capa.c | 2 +- wpa_supplicant/wpa_supplicant.c | 2 +- 4 [...] Content analysis details: (-0.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:631 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Replace the word Sane with Valid which is inclusive. Signed-off-by: Arowa Suliman --- src/drivers/driver.h | 4 ++-- src/drivers/driver_common.c | 2 +- src/drivers/driver_nl80211_capa.c | 2 +- wpa_supplicant/wpa_supplicant.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/drivers/driver.h b/src/drivers/driver.h index 804ac6806..4148ab07b 100644 --- a/src/drivers/driver.h +++ b/src/drivers/driver.h @@ -1894,11 +1894,11 @@ struct wpa_driver_capa { */ #define WPA_DRIVER_FLAGS_P2P_MGMT_AND_NON_P2P 0x00002000 /** - * Driver is known to use sane error codes, i.e., when it indicates that + * Driver is known to use valid error codes, i.e., when it indicates that * something (e.g., association) fails, there was indeed a failure and the * operation does not end up getting completed successfully later. */ -#define WPA_DRIVER_FLAGS_SANE_ERROR_CODES 0x00004000 +#define WPA_DRIVER_FLAGS_VALID_ERROR_CODES 0x00004000 /** Driver supports off-channel TX */ #define WPA_DRIVER_FLAGS_OFFCHANNEL_TX 0x00008000 /** Driver indicates TX status events for EAPOL Data frames */ diff --git a/src/drivers/driver_common.c b/src/drivers/driver_common.c index a7ebe9566..1cb976011 100644 --- a/src/drivers/driver_common.c +++ b/src/drivers/driver_common.c @@ -268,7 +268,7 @@ const char * driver_flag_to_string(u64 flag) DF2S(P2P_CAPABLE); DF2S(AP_TEARDOWN_SUPPORT); DF2S(P2P_MGMT_AND_NON_P2P); - DF2S(SANE_ERROR_CODES); + DF2S(VALID_ERROR_CODES); DF2S(OFFCHANNEL_TX); DF2S(EAPOL_TX_STATUS); DF2S(DEAUTH_TX_STATUS); diff --git a/src/drivers/driver_nl80211_capa.c b/src/drivers/driver_nl80211_capa.c index cd596e311..83868b78e 100644 --- a/src/drivers/driver_nl80211_capa.c +++ b/src/drivers/driver_nl80211_capa.c @@ -1389,7 +1389,7 @@ int wpa_driver_nl80211_capa(struct wpa_driver_nl80211_data *drv) WPA_DRIVER_AUTH_SHARED | WPA_DRIVER_AUTH_LEAP; - drv->capa.flags |= WPA_DRIVER_FLAGS_SANE_ERROR_CODES; + drv->capa.flags |= WPA_DRIVER_FLAGS_VALID_ERROR_CODES; drv->capa.flags |= WPA_DRIVER_FLAGS_SET_KEYS_AFTER_ASSOC_DONE; drv->capa.flags |= WPA_DRIVER_FLAGS_EAPOL_TX_STATUS; diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index 0d9b9caa5..89826ca26 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -3868,7 +3868,7 @@ static void wpas_start_assoc_cb(struct wpa_radio_work *work, int deinit) if (ret < 0) { wpa_msg(wpa_s, MSG_INFO, "Association request to the driver " "failed"); - if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_SANE_ERROR_CODES) { + if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_VALID_ERROR_CODES) { /* * The driver is known to mean what is saying, so we * can stop right here; the association will not