From patchwork Thu Oct 17 23:19:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 1179064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bjHP6pHB"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="dGKqUBRb"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46vQ9H14y2z9sPF for ; Fri, 18 Oct 2019 10:19:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=U+2P/lnBO7d+rqBF0KewvsFsEsGG+E3fDDBlIPCrfz8=; b=bjHP6pHBHmcwDQ dFaztVhhnGPDgPuCk3k2nK7peyiDwgl8hJJ7IqN7vYvR48nDZrLbrZPRLFie0LooRVSeemm++y4CE sIKnlKizcMHwndT9+2PpiLlp6lfjAvP1YlnMScByBaAG82zlT4FmlHvL1NeSVr5h30ivd6djXrA0Y VjcatA4KdyKTOYtfTFGpokEh7dOYLgQOKKulcn1MpAKkhWyw9hsIu9OfDcO8EZWqgUJW3C1uXlSxu //mU8fp63ojXLDpcxoDhQnf2voE3cFhEgysnExJI+/ya8lOAkGqaMqWkGKL66ZOIcVMEX6PgA8I97 Qf/0XgVGgqjYCOgtxO7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLF3E-0004hA-Ak; Thu, 17 Oct 2019 23:19:24 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLF3B-0004gs-UM for hostap@lists.infradead.org; Thu, 17 Oct 2019 23:19:23 +0000 Received: by mail-pf1-x443.google.com with SMTP id q7so2598867pfh.8 for ; Thu, 17 Oct 2019 16:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OjVm0+tln1CFG2bANNbC5IONSLcJJK4y8+tx+TpTvWM=; b=dGKqUBRbBmaZoQV6NfniSLrY0etf/M0P6d3YZuc1tzF1PDvvTOQExWvHVylnI2JSLK jt7xSLVhbObmfPJ3ljyOp7SANv12q7kSalELpIjsut4KRNfyOd1LnYfF/cHKsKsVgHnd hgeME8DB06PbJZYQf7LMkcw8JZizWoEoHvYYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OjVm0+tln1CFG2bANNbC5IONSLcJJK4y8+tx+TpTvWM=; b=dXQpGQu5wome6sqNKp9+2tqxHK1QnA/VKFnEreaabLJ870ITzKsoNgBGTj5/lfLir3 L5/YVyAUBRiKiuhq4kQ3laxthNkXck23lt5pI0pkCdjHNlDYq7z3UnS0aqlLWKFB0dbK ddeQ0vpFtON4A479+jcl7euVkXcxdVhFYcqya2L+hiln35FfTwCEQh8aS9PyUQaiAUbe Lx+63SacO7w/JpCNy1ngKbdwckNCE+8K9iFXq/jwCgR8nID8hDmcF16JGrXUP1NcaWKL JJsk9576qs5D2bUE0l+LqdkqjDqnci/gOszblJG7asJin2ISgtN7GM1VvSjIgYFWfPsv ULHQ== X-Gm-Message-State: APjAAAXNluwcR45oqUbpCFcQpd+/tYP0h+hNFQOuHpGAR+mraccvabNt /eLWNQzpnbqk6tGbZOGgfI0lDvjjZqo= X-Google-Smtp-Source: APXvYqwTzlnjJ12Vkd6bwRx6vRz/dqOkBx/ptEO+2D29zQADDIlBrbwha+nb6q5V0ni4El4ayWokdw== X-Received: by 2002:aa7:9ec5:: with SMTP id r5mr2904864pfq.230.1571354359854; Thu, 17 Oct 2019 16:19:19 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:534:b7c0:a63c:460c]) by smtp.gmail.com with ESMTPSA id l24sm3791838pff.151.2019.10.17.16.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 16:19:18 -0700 (PDT) From: Brian Norris To: hostap@lists.infradead.org Subject: [PATCH] Fix hostapd build with CONFIG_WPA_TRACE but no CONFIG_WPA_TRACE_BFD Date: Thu, 17 Oct 2019 16:19:15 -0700 Message-Id: <20191017231915.91237-1-briannorris@chromium.org> X-Mailer: git-send-email 2.23.0.866.gb869b98d4c-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191017_161922_002818_0074F6B4 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brian Norris Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Otherwise, we may get linker failures: ld.lld: error: unable to find library -lbfd While we're at it, pull in the library selection fixes from: 848905b12abf Avoid undefined references with CONFIG_WPA_TRACE_BFD=y Signed-off-by: Brian Norris --- hostapd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hostapd/Makefile b/hostapd/Makefile index 42bb9e4c8aa6..955e27856401 100644 --- a/hostapd/Makefile +++ b/hostapd/Makefile @@ -121,6 +121,7 @@ CFLAGS += -DPACKAGE="hostapd" -DWPA_TRACE_BFD LIBS += -lbfd -ldl -liberty -lz LIBS_c += -lbfd -ldl -liberty -lz LIBS_h += -lbfd -ldl -liberty -lz +LIBS_n += -lbfd -ldl -liberty -lz endif endif @@ -1313,7 +1314,6 @@ NOBJS += ../src/utils/wpa_debug.o NOBJS += ../src/utils/wpabuf.o ifdef CONFIG_WPA_TRACE NOBJS += ../src/utils/trace.o -LIBS_n += -lbfd endif HOBJS += hlr_auc_gw.o ../src/utils/common.o ../src/utils/wpa_debug.o ../src/utils/os_$(CONFIG_OS).o ../src/utils/wpabuf.o ../src/crypto/milenage.o