| Message ID | 20180828204433.28130-1-chaitanya.mgit@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] wpa_supplicant: owe: fix build error | expand |
On 28/08/18 22:44, chaitanya.mgit@gmail.com wrote: > From: Chaitanya T K <Chaitanya.Mgit@gmail.com> > > when CONFIG_OWE is enabled but none of 11R_AP/11W/FILS are enabled > the wpa_supplicant build fails. > > Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com> > --- > v3: add signed off > v2: updated comment as well. > --- > src/ap/drv_callbacks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c > index 6ec82e525..98a2eecc7 100644 > --- a/src/ap/drv_callbacks.c > +++ b/src/ap/drv_callbacks.c > @@ -109,10 +109,10 @@ int hostapd_notif_assoc(struct hostapd_data *hapd, const u8 *addr, > struct ieee802_11_elems elems; > const u8 *ie; > size_t ielen; > -#if defined(CONFIG_IEEE80211R_AP) || defined(CONFIG_IEEE80211W) || defined(CONFIG_FILS) > +#if defined(CONFIG_IEEE80211R_AP) || defined(CONFIG_IEEE80211W) || defined(CONFIG_FILS) || defined(CONFIG_OWE) > u8 buf[sizeof(struct ieee80211_mgmt) + 1024]; > u8 *p = buf; > -#endif /* CONFIG_IEEE80211R_AP || CONFIG_IEEE80211W || CONFIG_FILS */ > +#endif /* CONFIG_IEEE80211R_AP || CONFIG_IEEE80211W || CONFIG_FILS || CONFIG_OWE */ > u16 reason = WLAN_REASON_UNSPECIFIED; > u16 status = WLAN_STATUS_SUCCESS; > const u8 *p2p_dev_addr = NULL; > Isn't 802.11w for WPA3 (thus OWE) mandatory? To me this seems more like a missing dependancy in the makefile. BR Matthias
On Wed, Aug 29, 2018 at 11:31 AM Matthias May <matthias.may@neratec.com> wrote: > > On 28/08/18 22:44, chaitanya.mgit@gmail.com wrote: > > From: Chaitanya T K <Chaitanya.Mgit@gmail.com> > > > > when CONFIG_OWE is enabled but none of 11R_AP/11W/FILS are enabled > > the wpa_supplicant build fails. > > > > Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com> > > --- > > v3: add signed off > > v2: updated comment as well. > > --- > > src/ap/drv_callbacks.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c > > index 6ec82e525..98a2eecc7 100644 > > --- a/src/ap/drv_callbacks.c > > +++ b/src/ap/drv_callbacks.c > > @@ -109,10 +109,10 @@ int hostapd_notif_assoc(struct hostapd_data *hapd, const u8 *addr, > > struct ieee802_11_elems elems; > > const u8 *ie; > > size_t ielen; > > -#if defined(CONFIG_IEEE80211R_AP) || defined(CONFIG_IEEE80211W) || defined(CONFIG_FILS) > > +#if defined(CONFIG_IEEE80211R_AP) || defined(CONFIG_IEEE80211W) || defined(CONFIG_FILS) || defined(CONFIG_OWE) > > u8 buf[sizeof(struct ieee80211_mgmt) + 1024]; > > u8 *p = buf; > > -#endif /* CONFIG_IEEE80211R_AP || CONFIG_IEEE80211W || CONFIG_FILS */ > > +#endif /* CONFIG_IEEE80211R_AP || CONFIG_IEEE80211W || CONFIG_FILS || CONFIG_OWE */ > > u16 reason = WLAN_REASON_UNSPECIFIED; > > u16 status = WLAN_STATUS_SUCCESS; > > const u8 *p2p_dev_addr = NULL; > > > > Isn't 802.11w for WPA3 (thus OWE) mandatory? > To me this seems more like a missing dependancy in the makefile. Good point. But does OWE as a standalone needs 11w? There is no WPA3 config.
On Wed, Aug 29, 2018 at 02:14:33AM +0530, chaitanya.mgit@gmail.com wrote: > when CONFIG_OWE is enabled but none of 11R_AP/11W/FILS are enabled > the wpa_supplicant build fails. Thanks, applied.
diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c index 6ec82e525..98a2eecc7 100644 --- a/src/ap/drv_callbacks.c +++ b/src/ap/drv_callbacks.c @@ -109,10 +109,10 @@ int hostapd_notif_assoc(struct hostapd_data *hapd, const u8 *addr, struct ieee802_11_elems elems; const u8 *ie; size_t ielen; -#if defined(CONFIG_IEEE80211R_AP) || defined(CONFIG_IEEE80211W) || defined(CONFIG_FILS) +#if defined(CONFIG_IEEE80211R_AP) || defined(CONFIG_IEEE80211W) || defined(CONFIG_FILS) || defined(CONFIG_OWE) u8 buf[sizeof(struct ieee80211_mgmt) + 1024]; u8 *p = buf; -#endif /* CONFIG_IEEE80211R_AP || CONFIG_IEEE80211W || CONFIG_FILS */ +#endif /* CONFIG_IEEE80211R_AP || CONFIG_IEEE80211W || CONFIG_FILS || CONFIG_OWE */ u16 reason = WLAN_REASON_UNSPECIFIED; u16 status = WLAN_STATUS_SUCCESS; const u8 *p2p_dev_addr = NULL;