| Message ID | 20161206072650.23291-1-tomoharu.hatano@sonymobile.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Dec 06, 2016 at 04:26:50PM +0900, Tomoharu Hatano wrote: > Add p2p_add_cli_chan=1 option to p2p_supplicant.conf to allow wifi p2p > operating as GC on passive channels. > > In addition, add p2p_add_cli_chan=1 option to wpa_supplicant.conf > as well to have a consistency in p2p channel list. There is a case > where p2p channel list is updated with different channels from p2p > and wlan0. So this change in wpa_supplicant/wpa_supplicant_template.conf would only be for the purpose of changing Android default configuration, I'd assume (and if so, this would be good to note in the commit message). There is not really any P2P related items in that template file today.. Is it the best way of doing such a change for Android or is this something that the Wi-Fi framework should set instead? Is there a difference for OTA updates for this? I.e., is this change going to apply after such an update? I don't remember anymore how exactly the configuration file template is used..
Hi Jouni, Thank you for your feedback. > Is it the best way of doing such a change for Android or is this something that the Wi-Fi framework should set instead? We had several patches of wpa_supplicant for Android related to p2p connection of 5GHz. The patch can be fixed them. So, we think is it the best way to fix them. > Is there a difference for OTA updates for this? I.e., is this change going to apply after such an update? Sony Mobile has update mechanism for wpa_supplicant.conf by OTA. However, Android standard does not have it. Is it difficult to contribute in this case? Best Regards, Tomoharu Hatano -----Original Message----- From: Jouni Malinen [mailto:j@w1.fi] Sent: Wednesday, December 07, 2016 1:40 AM To: Hatano, Tomoharu (Sony Mobile) <Tomoharu.Hatano@sonymobile.com> Cc: hostap@lists.infradead.org; Kanstrup, Mikael <Mikael.Kanstrup@sonymobile.com> Subject: Re: [PATCH] Add p2p_add_cli_chan=1 option On Tue, Dec 06, 2016 at 04:26:50PM +0900, Tomoharu Hatano wrote: > Add p2p_add_cli_chan=1 option to p2p_supplicant.conf to allow wifi p2p > operating as GC on passive channels. > > In addition, add p2p_add_cli_chan=1 option to wpa_supplicant.conf as > well to have a consistency in p2p channel list. There is a case where > p2p channel list is updated with different channels from p2p and > wlan0. So this change in wpa_supplicant/wpa_supplicant_template.conf would only be for the purpose of changing Android default configuration, I'd assume (and if so, this would be good to note in the commit message). There is not really any P2P related items in that template file today.. Is it the best way of doing such a change for Android or is this something that the Wi-Fi framework should set instead? Is there a difference for OTA updates for this? I.e., is this change going to apply after such an update? I don't remember anymore how exactly the configuration file template is used..
On Tue, Dec 13, 2016 at 12:34:28AM +0000, Hatano, Tomoharu (Sony Mobile) wrote: > We had several patches of wpa_supplicant for Android related to p2p connection of 5GHz. > The patch can be fixed them. > So, we think is it the best way to fix them. OK > Sony Mobile has update mechanism for wpa_supplicant.conf by OTA. > However, Android standard does not have it. > Is it difficult to contribute in this case? That's fine, I just wanted to make sure that the impact of configuration file changes with OTA is understood. I applied the patch with an additional note in the commit message for this.
diff --git a/wpa_supplicant/wpa_supplicant_template.conf b/wpa_supplicant/wpa_supplicant_template.conf index f3f2a64..f55227f 100644 --- a/wpa_supplicant/wpa_supplicant_template.conf +++ b/wpa_supplicant/wpa_supplicant_template.conf @@ -4,3 +4,4 @@ eapol_version=1 ap_scan=1 fast_reauth=1 pmf=1 +p2p_add_cli_chan=1