| Message ID | 1664612489-29288-2-git-send-email-quic_vjakkam@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | MLD STA: Add support for four-way handshake and SAE external authentication | expand |
Hi, > +/* > + * STA control field definitions of Per-STA Profile subelement in Basic > + * Multi-Link element as described in Figure 9-1002n: STA Control field > format. > + */ > +#define BASIC_ML_STA_CNTRL0_LINK_ID_SHIFT 0 Use 'BASIC_ML_STA_CTRL0_LINK_ID_SHIFT' to be consistent with other definitions below. > +#define BASIC_ML_STA_CTRL0_LINK_ID_MASK 0x0F > +#define BASIC_ML_STA_CTRL0_COMPLETE_PROFILE 0x10 > +#define BASIC_ML_STA_CTRL0_PRES_STA_MAC 0x20 > +#define BASIC_ML_STA_CTRL0_PRES_BEACON_INT 0x40 > +#define BASIC_ML_STA_CTRL0_PRES_TSF_OFFSET 0x80 > +#define BASIC_ML_STA_CTRL1_PRES_DTIM_INFO 0x10 > +#define BASIC_ML_STA_CTRL1_PRES_NSTR_LINK_PAIR 0x20 > +#define BASIC_ML_STA_CTRL1_PRES_NSTR_BITMAP 0x40 > +#define BASIC_ML_STA_CTRL1_PRES_BSS_PARAM_COUNT 0x80 > + The definitions for CTRL1 seem to be wrong. They all should be shifted right by 4. Regards, Ilan.
On 10/3/2022 5:59 PM, Peer, Ilan wrote: > Use 'BASIC_ML_STA_CTRL0_LINK_ID_SHIFT' to be consistent with other definitions below. sure > +#define BASIC_ML_STA_CTRL1_PRES_DTIM_INFO 0x10 > +#define BASIC_ML_STA_CTRL1_PRES_NSTR_LINK_PAIR 0x20 > +#define BASIC_ML_STA_CTRL1_PRES_NSTR_BITMAP 0x40 > +#define BASIC_ML_STA_CTRL1_PRES_BSS_PARAM_COUNT 0x80 > + > The definitions for CTRL1 seem to be wrong. They all should be shifted right by 4. Thanks. I will fix it in v3 series
diff --git a/src/common/ieee802_11_defs.h b/src/common/ieee802_11_defs.h index 0317f9d..00d773c 100644 --- a/src/common/ieee802_11_defs.h +++ b/src/common/ieee802_11_defs.h @@ -2527,6 +2527,16 @@ struct ieee80211_eht_capabilities { #define MULTI_LINK_CONTROL_TYPE_TDLS 3 #define MULTI_LINK_CONTROL_TYPE_PRIOR_ACCESS 4 +/* + * Table 9-401d: Optional subelement IDs for Link Info field of the Multi-Link + * element + */ +#define MULTI_LINK_SUB_ELEM_ID_PER_STA_PROFILE 0 +#define MULTI_LINK_SUB_ELEM_ID_VENDOR 221 +#define MULTI_LINK_SUB_ELEM_ID_FRAGMENT 254 + +/* IEEE P802.11be/D2.1, 9.4.2.312.2 - Basic Multi-Link element */ + /* Figure 9-1002g: Presence Bitmap subfield of the Basic Multi-Link element */ #define BASIC_MULTI_LINK_CTRL0_PRES_LINK_ID 0x10 #define BASIC_MULTI_LINK_CTRL0_PRES_BSS_PARAM_CH_COUNT 0x20 @@ -2536,6 +2546,21 @@ struct ieee80211_eht_capabilities { #define BASIC_MULTI_LINK_CTRL1_PRES_MLD_CAPA 0x01 #define BASIC_MULTI_LINK_CTRL1_PRES_AP_MLD_ID 0x02 +/* + * STA control field definitions of Per-STA Profile subelement in Basic + * Multi-Link element as described in Figure 9-1002n: STA Control field format. + */ +#define BASIC_ML_STA_CNTRL0_LINK_ID_SHIFT 0 +#define BASIC_ML_STA_CTRL0_LINK_ID_MASK 0x0F +#define BASIC_ML_STA_CTRL0_COMPLETE_PROFILE 0x10 +#define BASIC_ML_STA_CTRL0_PRES_STA_MAC 0x20 +#define BASIC_ML_STA_CTRL0_PRES_BEACON_INT 0x40 +#define BASIC_ML_STA_CTRL0_PRES_TSF_OFFSET 0x80 +#define BASIC_ML_STA_CTRL1_PRES_DTIM_INFO 0x10 +#define BASIC_ML_STA_CTRL1_PRES_NSTR_LINK_PAIR 0x20 +#define BASIC_ML_STA_CTRL1_PRES_NSTR_BITMAP 0x40 +#define BASIC_ML_STA_CTRL1_PRES_BSS_PARAM_COUNT 0x80 + /* IEEE P802.11ay/D4.0, 9.4.2.251 - EDMG Operation element */ #define EDMG_BSS_OPERATING_CHANNELS_OFFSET 6 #define EDMG_OPERATING_CHANNEL_WIDTH_OFFSET 7
Define subelement IDs and Per-STA Profile STA control fields of Basic Multi-Link element as described in IEEE P802.11be/D2.1. Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com> --- src/common/ieee802_11_defs.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)