diff mbox series

[v2] driver_nl80211: skip frame filter config for P2P-Device

Message ID 1612470400-Ifb8df0dca1aa3d952733b3db30060243db7e72b7@changeid
State Accepted
Headers show
Series [v2] driver_nl80211: skip frame filter config for P2P-Device | expand

Commit Message

Johannes Berg Feb. 4, 2021, 8:26 p.m. UTC 
From: Johannes Berg <johannes.berg@intel.com>

There's no point in attempting to configure frame filters on
a P2P-Devices that doesn't even have a netdev (nor passes any
data traffic), that just results in error messages. Skip it.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
v2: return 0, oops
---
 src/drivers/driver_nl80211.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jouni Malinen Feb. 6, 2021, 10:15 a.m. UTC | #1 
On Thu, Feb 04, 2021 at 09:26:40PM +0100, Johannes Berg wrote:
> There's no point in attempting to configure frame filters on
> a P2P-Devices that doesn't even have a netdev (nor passes any
> data traffic), that just results in error messages. Skip it.

Thanks, applied.
diff mbox series

Patch

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 919c6128d8f1..a137ba293186 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -11506,6 +11506,10 @@  static int nl80211_configure_data_frame_filters(void *priv, u32 filter_flags)
 	char path[128];
 	int ret;
 
+	/* P2P-Device has no netdev that can (or should) be configured here */
+	if (nl80211_get_ifmode(bss) == NL80211_IFTYPE_P2P_DEVICE)
+		return 0;
+
 	wpa_printf(MSG_DEBUG, "nl80211: Data frame filter flags=0x%x",
 		   filter_flags);