diff mbox

ap: use is_broadcast_ether_addr()

Message ID 1470396714-22508-1-git-send-email-johannes@sipsolutions.net
State Accepted
Headers show

Commit Message

Johannes Berg Aug. 5, 2016, 11:31 a.m. UTC 
From: Johannes Berg <johannes.berg@intel.com>

There's no need to have a separate variable and open-code a more
complicated version of this, just use is_broadcast_ether_addr().

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 src/ap/ieee802_11.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Jouni Malinen Aug. 6, 2016, 9:22 p.m. UTC | #1 
On Fri, Aug 05, 2016 at 01:31:54PM +0200, Johannes Berg wrote:
> There's no need to have a separate variable and open-code a more
> complicated version of this, just use is_broadcast_ether_addr().

Thanks, applied.
diff mbox

Patch

diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
index 781afa227714..a24e8e88377a 100644
--- a/src/ap/ieee802_11.c
+++ b/src/ap/ieee802_11.c
@@ -2551,7 +2551,6 @@  int ieee802_11_mgmt(struct hostapd_data *hapd, const u8 *buf, size_t len,
 		    struct hostapd_frame_info *fi)
 {
 	struct ieee80211_mgmt *mgmt;
-	int broadcast;
 	u16 fc, stype;
 	int ret = 0;
 
@@ -2567,11 +2566,7 @@  int ieee802_11_mgmt(struct hostapd_data *hapd, const u8 *buf, size_t len,
 		return 1;
 	}
 
-	broadcast = mgmt->bssid[0] == 0xff && mgmt->bssid[1] == 0xff &&
-		mgmt->bssid[2] == 0xff && mgmt->bssid[3] == 0xff &&
-		mgmt->bssid[4] == 0xff && mgmt->bssid[5] == 0xff;
-
-	if (!broadcast &&
+	if (!is_broadcast_ether_addr(mgmt->bssid) &&
 #ifdef CONFIG_P2P
 	    /* Invitation responses can be sent with the peer MAC as BSSID */
 	    !((hapd->conf->p2p & P2P_GROUP_OWNER) &&