From patchwork Fri Jul 21 23:23:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 792384 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-82339-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="vWVvdgrV"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xDmzg2dcnz9s7m for ; Sat, 22 Jul 2017 09:23:43 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; q=dns; s=default; b=CBXsLr26Z8UEUMsK UHzA7w+L1gjVErGy/jHYKB98VrhbZAa0AHZEm7mqJgWr4+ALalCmW2E/4/QvOUCG PhhdI8LeI45nMTHynsGyvJP32ElrpUh6DnpbZICabGmpJLJtxtr0HoyRyyipqP7E 39AkpR+RdVwrp/Kkr8OQP0QaNZM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=default; bh=N7ZDPNZ5/tnR1ZTb+vcLyH cViqY=; b=vWVvdgrVY9amdin4vYDf215mebeSQuo14zfknmPArSOYCgZ+bQ9b8n Ny+efmIOZv3VcXy868pedwQbFFHwMlVn3DgnzIWFsIEms2SEW8fJu/LQ9AvzKIXL 2oeEBdVF84UbNqQVQEd+Bvj6st1QeNTlIvlLNfcNi1b2JrqavLi5A= Received: (qmail 122263 invoked by alias); 21 Jul 2017 23:23:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 122221 invoked by uid 89); 21 Jul 2017 23:23:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A9C085545 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9A9C085545 From: DJ Delorie To: "H.J. Lu" Cc: sellcey@cavium.com, libc-alpha@sourceware.org Subject: Re: [Patch] Fix nss/nss_test1.c compile with latest GCC In-Reply-To: <20170721231747.GA19787@gmail.com> (hjl.tools@gmail.com) Date: Fri, 21 Jul 2017 19:23:30 -0400 Message-ID: MIME-Version: 1.0 I think the right solution is to fix test5. I suspect that leaving in "bad" default data is a good test for a properly configured test,a and we might want to add some "bad" default group data as well. diff --git a/nss/tst-nss-test5.c b/nss/tst-nss-test5.c index b70f21e..fef41f0 100644 --- a/nss/tst-nss-test5.c +++ b/nss/tst-nss-test5.c @@ -65,7 +65,7 @@ do_test (void) int i; struct passwd *p; - __nss_configure_lookup ("passwd", "test1 test2"); + __nss_configure_lookup ("passwd", "test1"); setpwent ();