From patchwork Wed Jul 5 15:24:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike FABIAN X-Patchwork-Id: 784684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x2l7h3hwPz9s7f for ; Thu, 6 Jul 2017 01:25:52 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="PlOwEltt"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=fENa5 i1rdT8ov2I8SwBbzexzrAGM2hYdoKLUbfi6jAGzYDivVIvpJdVG5QG9/fxu7+Mrn LbbhvJ0SKaRRP/+JBFL/nC8TC28KRq0nIA+OuklX1IxUVnurEnqDtRvxjotXhluN lOlYRm5L2xCMHpilAPYutgmK9LLIbv7H+otsPs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=u1FpvCHCg5A xC51V0snOgafFxgo=; b=PlOwElttt0h/aWg0JddVbHDl6mu2LZ712uLaFdNCVKG o40TqdoiSa9IW6YXqpF8tvFajvg4c3Nz8c3obZm8yLZtpYopY+qEWwCyAddaohuT SFdIYmkrXJYacxr0Tu8GpIIrG+EAovFxHgnSmH5wspe1XOzy1FULAZwLTYdDnrM0 = Received: (qmail 7939 invoked by alias); 5 Jul 2017 15:24:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 7653 invoked by uid 89); 5 Jul 2017 15:24:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_00, BODY_8BITS, GARBLED_BODY, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS, T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=postal X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9C9F3C04B954 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9C9F3C04B954 From: Mike FABIAN To: Akhilesh Kumar Cc: libc-alpha@sourceware.org, pankaj.m@samsung.com, hakbong5.lee@samsung.com, maninder1.s@samsung.com Subject: Re: [PATCH 2/2] Added new Fiji Hindi locales. References: <1499059051-6540-1-git-send-email-akhilesh.k@samsung.com> Date: Wed, 05 Jul 2017 17:24:11 +0200 In-Reply-To: <1499059051-6540-1-git-send-email-akhilesh.k@samsung.com> (Akhilesh Kumar's message of "Mon, 3 Jul 2017 10:47:31 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Akhilesh Kumar さんはかきました: > [BZ #21694] > Added Fiji Hindi language locale same as Hindi for Fiji. > > Signed-off-by: Akhilesh Kumar > --- > locale/iso-639.def | 1 + > localedata/SUPPORTED | 1 + > localedata/locales/hif_FJ | 138 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 140 insertions(+) > create mode 100644 localedata/locales/hif_FJ > > diff --git a/locale/iso-639.def b/locale/iso-639.def > index 5e8c048..4a3801c 100644 > --- a/locale/iso-639.def > +++ b/locale/iso-639.def > @@ -150,6 +150,7 @@ DEFINE_LANGUAGE_CODE3 ("Ewondo", ewo, ewo) > DEFINE_LANGUAGE_CODE3 ("Fang", fan, fan) > DEFINE_LANGUAGE_CODE3 ("Fanti", fat, fat) > DEFINE_LANGUAGE_CODE ("Faroese", fo, fao, fao) > +DEFINE_LANGUAGE_CODE3 ("FijiHindi", hif, hif) ^ space missing > DEFINE_LANGUAGE_CODE ("Fijian", fj, fij, fij) > DEFINE_LANGUAGE_CODE3 ("Filipino; Pilipino", fil, fil) > DEFINE_LANGUAGE_CODE ("Finnish", fi, fin, fin) [...] > diff --git a/localedata/locales/hif_FJ b/localedata/locales/hif_FJ > new file mode 100644 > index 0000000..a2fca5b > --- /dev/null > +++ b/localedata/locales/hif_FJ > @@ -0,0 +1,138 @@ > +comment_char % > +escape_char / > + > +% Fiji Hindi language locale same as Hindi for Fiji. > +% Contributed by Akhilesh Kumar . > +% Wrods translated from https://en.wikipedia.org/wiki/Fiji_Hindi ^Words > + > +LC_IDENTIFICATION > +title "Fiji Hinda language locale for Fiji" ^i [...] [...] > +LC_TIME > +% Full month names > +copy "hi_IN" > +END LC_TIME > +% You copy the month names here from hi_IN, which are in Devanagari script. Therefore, LC_MESSAGES and LC_NAME should also copy hi_IN and not en_US. I am not sure which script is most commonly used for Fiji Hindi. https://hif.wikipedia.org/wiki/Fiji seems to use Latin script. But https://en.wikipedia.org/wiki/Fiji_Hindi lists “Devanagari” first under “Writing System”. If we want this locale to use Devanagari script, we can use copy "hi_IN" as I suggested above. But if we want this locale to use Latin script, we should create new LC_TIME, LC_MESSAGES, and LC_NAME sections. What do we want here? [...] > +LC_MEASUREMENT > +measurement 1 > +END LC_MEASUREMENT > + > +LC_MESSAGES > +% fix me > +copy "en_US" > +END LC_MESSAGES copy hi_IN here instead of en_US > +LC_NAME > +% fix me > +copy "en_US" > +END LC_NAME copy hi_IN here instead of en_US > +LC_ADDRESS > +% http://www.bitboost.com/ref/international-address-formats/fiji/ > +% %n%s%l%c > +postal_fmt "" After reading http://www.bitboost.com/ref/international-address-formats/fiji/ , I think this is more correct: +% %a%N%h%t%s%N%l%N%T%c +postal_fmt "" > +% Fiji > +country_name "" > +% No code > +country_post "" > +% http://laendercode.net/en/2-letter-list.html > +% FJ > +country_ab2 "" > +% FJI > +% http://laendercode.net/en/countries.html > +country_ab3 "" > +country_car "" > +country_num 242 > +% http://www.nationsonline.org/oneworld/international-calling-codes.htm The last comment is in the wrong section, should be in LC_TELEPHONE. > +% Fiji Hindi > +% https://en.wikipedia.org/wiki/Fiji_Hindi > +lang_name "" lang_name should contain the language endonym, i.e. the name of the language in that language. So when using Devanagari script it should be +% फ़िजी बात +lang_name "" Or, when using Latin script it should be "Fiji Baat", see https://en.wikipedia.org/wiki/Fiji_Hindi > +% tp > +% Fix Me > +% lang_ab "" > +% hif > +lang_term "" Maybe add empty lang_ab and lang_lib for clarity: +% iso-639-1 "" +lang_ab "" +% iso-639-3 hif lang_term "" +% iso-639-2 "" +lang_lib "" > +END LC_ADDRESS > + > +LC_TELEPHONE > +% https://www.howtocallabroad.com/fiji/ > +% +%c ;%l > +tel_int_fmt "" Reading the URL makes me think the “;” is not needed, i.e. this should be: +% +%c %l +tel_int_fmt "" > +% 00 > +int_select "" > +% 679 > +int_prefix "" > +END LC_TELEPHON ^E is missing Attached is a patch with the changes I suggest. From bbdd044fee013428a6dc976dbe1797f0511459d0 Mon Sep 17 00:00:00 2001 From: Mike FABIAN Date: Wed, 5 Jul 2017 16:59:48 +0200 Subject: [PATCH] hif_FJ: fix whitespace and typos; for LC_MESSAGES and LC_NAME copy hi_IN instead of en_US; improve postal format; use the language endonym in lang_name instead of the English language name; Fix tel_int_fmt; Add missing final E in "END LC_TELEPHONE" --- locale/iso-639.def | 2 +- localedata/locales/hif_FJ | 59 ++++++++++++++++++++++------------------------- 2 files changed, 29 insertions(+), 32 deletions(-) diff --git a/locale/iso-639.def b/locale/iso-639.def index 4a3801cd8a..0fefadcc68 100644 --- a/locale/iso-639.def +++ b/locale/iso-639.def @@ -150,7 +150,7 @@ DEFINE_LANGUAGE_CODE3 ("Ewondo", ewo, ewo) DEFINE_LANGUAGE_CODE3 ("Fang", fan, fan) DEFINE_LANGUAGE_CODE3 ("Fanti", fat, fat) DEFINE_LANGUAGE_CODE ("Faroese", fo, fao, fao) -DEFINE_LANGUAGE_CODE3 ("FijiHindi", hif, hif) +DEFINE_LANGUAGE_CODE3 ("Fiji Hindi", hif, hif) DEFINE_LANGUAGE_CODE ("Fijian", fj, fij, fij) DEFINE_LANGUAGE_CODE3 ("Filipino; Pilipino", fil, fil) DEFINE_LANGUAGE_CODE ("Finnish", fi, fin, fin) diff --git a/localedata/locales/hif_FJ b/localedata/locales/hif_FJ index a2fca5b04d..d216c2f7cc 100644 --- a/localedata/locales/hif_FJ +++ b/localedata/locales/hif_FJ @@ -1,18 +1,18 @@ comment_char % escape_char / -% Fiji Hindi language locale same as Hindi for Fiji. +% Fiji Hindi language locale same as Hindi for Fiji. % Contributed by Akhilesh Kumar . -% Wrods translated from https://en.wikipedia.org/wiki/Fiji_Hindi +% Words translated from https://en.wikipedia.org/wiki/Fiji_Hindi LC_IDENTIFICATION -title "Fiji Hinda language locale for Fiji" +title "Fiji Hindi language locale for Fiji" source "Samsung Electronics Co., Ltd." address "" contact "" email "akhilesh.k@samsung.com" -tel "" -fax "" +tel "" +fax "" language "Fiji Hindi" territory "Fiji" revision "0.1" @@ -42,7 +42,7 @@ END LC_CTYPE LC_COLLATE % Copy the template from ISO/IEC 3166 -copy "iso14651_t1" +copy "iso14651_t1" END LC_COLLATE LC_TIME @@ -55,12 +55,11 @@ copy "hi_IN" END LC_NUMERIC % -% https://en.wikipedia.org/wiki/Fijian_dollar +% https://en.wikipedia.org/wiki/Fijian_dollar % currency sign: FJ$, $; currency code: FJD) -% FJ$ or FJD +% FJ$ or FJD % $ LC_MONETARY -% fix me currency_symbol "" int_curr_symbol "" mon_decimal_point "" @@ -81,58 +80,56 @@ n_sign_posn 1 END LC_MONETARY LC_PAPER -% fix me copy "i18n" END LC_PAPER LC_MEASUREMENT -measurement 1 +copy "i18n" END LC_MEASUREMENT LC_MESSAGES -% fix me -copy "en_US" +copy "hi_IN" END LC_MESSAGES LC_NAME -% fix me -copy "en_US" +copy "hi_IN" END LC_NAME LC_ADDRESS % http://www.bitboost.com/ref/international-address-formats/fiji/ -% %n%s%l%c -postal_fmt "" -% Fiji +% %a%N%h%t%s%N%l%N%T%c +postal_fmt "" +% Fiji country_name "" -% No code +% No code country_post "" % http://laendercode.net/en/2-letter-list.html % FJ country_ab2 "" -% FJI +% FJI % http://laendercode.net/en/countries.html country_ab3 "" -country_car "" +country_car "" +% https://en.wikipedia.org/wiki/ISO_3166-1_numeric country_num 242 -% http://www.nationsonline.org/oneworld/international-calling-codes.htm -% Fiji Hindi % https://en.wikipedia.org/wiki/Fiji_Hindi -lang_name "" -% tp -% Fix Me -% lang_ab "" -% hif +% फ़िजी बात +lang_name "" +% iso-639-1 "" +lang_ab "" +% iso-639-3 hif lang_term "" +% iso-639-2 "" +lang_lib "" END LC_ADDRESS LC_TELEPHONE % https://www.howtocallabroad.com/fiji/ -% +%c ;%l -tel_int_fmt "" +% +%c %l +tel_int_fmt "" % 00 int_select "" % 679 int_prefix "" -END LC_TELEPHON +END LC_TELEPHONE -- 2.13.0