From patchwork Tue Apr 5 15:05:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 606499 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qfXGR2ZzPz9t5Y for ; Wed, 6 Apr 2016 01:05:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=HDLwUIIJ; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=vX1x u4eq6PQwW/SR0MtwclK7bryVqhiMY/MBop3Z+INvFZcFOCOMgJOzVWSTWjHKw3TR 2Er8u9ErNgJ2AK6Opk/zjnL2GekjFXjix5TAxgHsRGcoLsM7cjE5Zi0K2ipktIJq K6t3UedyqfKvstVbcR625FJ0pVuvTcrsXKfvSi4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=RdZahpzWKJ ey0FWCGX6xOkVFzHs=; b=HDLwUIIJhL+qwB9EcWaYxdJ61flqraFTlLP43V7jmE s/TiUzyqTeWlVQsFv4fjHWoPUtqmlALSafNOA86LlEFqs9/BGz/PdNRfovXLHNR9 HMOtgsnIn7dS8YVyoSHVNFkIS1CFBFyY24t6SrWmIDeN97DHXH9+oSubnnFGIjpA 0= Received: (qmail 60197 invoked by alias); 5 Apr 2016 15:05:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 60180 invoked by uid 89); 5 Apr 2016 15:05:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=2099, sk:hack_di, hack_digit, 209, 9 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler Subject: Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633] Date: Tue, 5 Apr 2016 17:05:00 +0200 Lines: 81 Message-ID: References: <56CF62D0.8060803@redhat.com> <56CF7D30.2090000@redhat.com> <56DD80AF.3000408@redhat.com> <56DD9E1C.5030408@redhat.com> <56DDA516.4090509@redhat.com> <56DDB33A.1000405@redhat.com> <56DDDF0D.8040601@redhat.com> <56FBBDE3.2050106@redhat.com> <56FBEBED.6050206@gmail.com> <57027826.4000308@redhat.com> Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 In-Reply-To: On 04/05/2016 02:50 PM, Andreas Schwab wrote: > Stefan Liebler writes: > >> diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c >> index baada9e..fb2a763 100644 >> --- a/stdio-common/printf_fp.c >> +++ b/stdio-common/printf_fp.c >> @@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc, >> } >> return done; >> } >> -ldbl_hidden_def (___printf_fp_l, __printf_fp_l) >> -ldbl_strong_alias (___printf_fp_l, __printf_fp_l) >> +libc_hidden_def (__printf_fp_l) >> +strong_alias (___printf_fp_l, __printf_fp_l) > > Please rename ___printf_fp_l to __printf_fp_l, no need for the alias. > Otherwise looks ok. > > Andreas. > Here is an updated patch to reflect the mentioned changes. Okay to commit? ChangeLog: 2016-04-05 Stefan Liebler * stdio-common/printf_fp.c (__printf_fp_l): Rename ___printf_fp_l to __printf_fp_l and remove strong alias. Use libc_hidden_def instead of ldbl_hidden_def macro. diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c index baada9e..fdfe06b 100644 --- a/stdio-common/printf_fp.c +++ b/stdio-common/printf_fp.c @@ -209,9 +209,9 @@ hack_digit (struct hack_digit_param *p) } int -___printf_fp_l (FILE *fp, locale_t loc, - const struct printf_info *info, - const void *const *args) +__printf_fp_l (FILE *fp, locale_t loc, + const struct printf_info *info, + const void *const *args) { /* The floating-point value to output. */ union @@ -1248,14 +1248,13 @@ ___printf_fp_l (FILE *fp, locale_t loc, } return done; } -ldbl_hidden_def (___printf_fp_l, __printf_fp_l) -ldbl_strong_alias (___printf_fp_l, __printf_fp_l) +libc_hidden_def (__printf_fp_l) int ___printf_fp (FILE *fp, const struct printf_info *info, const void *const *args) { - return ___printf_fp_l (fp, _NL_CURRENT_LOCALE, info, args); + return __printf_fp_l (fp, _NL_CURRENT_LOCALE, info, args); } ldbl_hidden_def (___printf_fp, __printf_fp) ldbl_strong_alias (___printf_fp, __printf_fp)