diff mbox

[1/1] Added Tok-Pisin locale.

Message ID def38421-42cb-a9c2-5673-2cd30965741e@redhat.com
State New
Headers show

Commit Message

Carlos O'Donell July 5, 2017, 6:15 p.m. UTC 
On 07/05/2017 12:39 PM, Mike FABIAN wrote:
> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
> 
>> +category  "i18n:2017";LC_IDENTIFICATION
>> +category  "i18n:2017";LC_CTYPE
>> +category  "i18n:2017";LC_COLLATE
>> +category  "i18n:2017";LC_TIME
>> +category  "i18n:2017";LC_NUMERIC
>> +category  "i18n:2017";LC_MONETARY
>> +category  "i18n:2017";LC_PAPER
>> +category  "i18n:2017";LC_MEASUREMENT
>> +category  "i18n:2017";LC_MESSAGES
>> +category  "i18n:2017";LC_NAME
>> +category  "i18n:2017";LC_ADDRESS
>> +category  "i18n:2017";LC_TELEPHONE
>> +END LC_IDENTIFICATION
> 
> This causes an error when building the locale:
> 
> tpi_PG.UTF-8...LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_CTYPE'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_NUMERIC'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_TIME'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_COLLATE'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_MONETARY'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_MESSAGES'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_PAPER'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_NAME'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_ADDRESS'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_TELEPHONE'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_MEASUREMENT'
> LC_IDENTIFICATION: unknown standard `i18n:2017' for category `LC_IDENTIFICATION'
> 
> 
> All the other locales have `i18n:2012'.
> 
> I’ll change it to `i18n:2012' before committing your patch.
 
I cleaned up the ChangeLog for this. Please keep an eye on GNU ChangeLog
convention. It should be present tense, and explain which files are being
changed and how. You can add a leading paragraph that explains the change
too.

Carlos.

Comments

Mike FABIAN July 6, 2017, 6:59 a.m. UTC | #1 
Carlos O'Donell <carlos@redhat.com> さんはかきました:

> diff --git a/localedata/ChangeLog b/localedata/ChangeLog
> index d291642..fab25f0 100644
> --- a/localedata/ChangeLog
> +++ b/localedata/ChangeLog
> @@ -1,7 +1,10 @@
>  2017-07-05  Akhilesh Kumar <akhilesh.k@samsung.com>
>  
> +       Added tok-pisin language locale for Papua New Guinea.
> +
>         [BZ #21694]
> -       * Added tok-pisin language locale for Papua New Guinea.
> +       * locales/tpi_PG: New file.
> +       * SUPPORTED: Add tpi_PG/UTF-8.
>  

OK, thank you!
diff mbox

Patch

diff --git a/localedata/ChangeLog b/localedata/ChangeLog
index d291642..fab25f0 100644
--- a/localedata/ChangeLog
+++ b/localedata/ChangeLog
@@ -1,7 +1,10 @@ 
 2017-07-05  Akhilesh Kumar <akhilesh.k@samsung.com>
 
+       Added tok-pisin language locale for Papua New Guinea.
+
        [BZ #21694]
-       * Added tok-pisin language locale for Papua New Guinea.
+       * locales/tpi_PG: New file.
+       * SUPPORTED: Add tpi_PG/UTF-8.
 
---

-- 
Cheers,