From patchwork Sun Apr 12 19:30:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerald Pfeifer X-Patchwork-Id: 460543 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7FEC914012F for ; Mon, 13 Apr 2015 05:30:33 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=sourceware.org header.i=@sourceware.org header.b=rU1wggcd; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=bEIsr JRS4fY3yO5+fnCnbKksNZQwtfp25i/L+gV5/AG5ZdqHq2lf1cuWUP4bny74DqiYX +cHdV09YjHfH6HiKVjd8PEW7iqVI/6iL+raVwdQylBva4UL9OPFlZRsGrW2NqFks HteZonshXAlkCdDfB98Nfy0SVYLC6ScP/k0m7M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=LSsAfq4EmYr 2F5fPo4GwBMAyvJU=; b=rU1wggcd2nDhKZh05trJK4b9n3JqKTZbyYvsOZ5bGcP JUdpeko83Hy/nKzpPuE2sBpAPsu9tdvT64B0vb+yQy5wO2EAgUDmsB/m8x3YQ5ay GVlMhIHGr1QWVnnRfW3PM9qNqJQD9+V2ZNhVQwCXtrDIPhEnVvqxJfs7t1H02oRg = Received: (qmail 96981 invoked by alias); 12 Apr 2015 19:30:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 96952 invoked by uid 89); 12 Apr 2015 19:30:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: ainaz.pair.com Date: Sun, 12 Apr 2015 21:30:02 +0200 (CEST) From: Gerald Pfeifer To: Jakub Jelinek cc: Jason Merrill , "Joseph S. Myers" , =?ISO-8859-15?Q?Manuel_L=F3pez-Ib=E1=F1ez?= , Gcc Patch List , Richard Biener , Siddhesh Poyarekar , Carlos O'Donell , GNU C Library Subject: Re: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2) In-Reply-To: <20140711201852.GD31640@tucnak.redhat.com> Message-ID: References: <53BDB402.20309@redhat.com> <20140710125222.GI31640@tucnak.redhat.com> <20140711201852.GD31640@tucnak.redhat.com> MIME-Version: 1.0 Hi Jakub, On Fri, 11 Jul 2014, Jakub Jelinek wrote: > So like this? Also have fixed one omitted line in c-parser.c, > this patch bootstrapped/regtested fine: just in time for GCC 5.1 RC1 :-) a small update on top of yours. Committed. Gerald 2015-04-12 Gerald Pfeifer * doc/invoke.texi (-Wmemset-transposed-args): Break a long sentence. Improve grammar. Index: doc/invoke.texi =================================================================== --- doc/invoke.texi (revision 222021) +++ doc/invoke.texi (working copy) @@ -4909,10 +4909,10 @@ second argument is not zero and the third argument is zero. This warns e.g.@ about @code{memset (buf, sizeof buf, 0)} where most probably @code{memset (buf, 0, sizeof buf)} was meant instead. The diagnostics -is only emitted if the third argument is literal zero, if it is some expression -that is folded to zero, or e.g. a cast of zero to some type etc., it -is far less likely that user has mistakenly exchanged the arguments and -no warning is emitted. This warning is enabled by @option{-Wall}. +is only emitted if the third argument is literal zero. If it is some +expression that is folded to zero, a cast of zero to some type, etc., +it is far less likely that the user has mistakenly exchanged the arguments +and no warning is emitted. This warning is enabled by @option{-Wall}. @item -Waddress @opindex Waddress