diff mbox series

Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h

Message ID alpine.DEB.2.22.394.2112092141450.72995@digraph.polyomino.org.uk
State New
Headers show
Series Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h | expand

Commit Message

Joseph Myers Dec. 9, 2021, 9:42 p.m. UTC
Add the constant ARPHRD_MCTP, from Linux 5.15, to net/if_arp.h, along
with ARPHRD_CAN which was added to Linux in version 2.6.25 (commit
cd05acfe65ed2cf2db683fa9a6adb8d35635263b, "[CAN]: Allocate protocol
numbers for PF_CAN") but apparently missed for glibc at the time.

Tested for x86_64.

Comments

Joseph Myers Dec. 16, 2021, 9:57 p.m. UTC | #1
Ping.  This patch 
<https://sourceware.org/pipermail/libc-alpha/2021-December/133936.html> is 
pending review.
Florian Weimer Dec. 17, 2021, 11:56 a.m. UTC | #2
* Joseph Myers:

> Add the constant ARPHRD_MCTP, from Linux 5.15, to net/if_arp.h, along
> with ARPHRD_CAN which was added to Linux in version 2.6.25 (commit
> cd05acfe65ed2cf2db683fa9a6adb8d35635263b, "[CAN]: Allocate protocol
> numbers for PF_CAN") but apparently missed for glibc at the time.
>
> Tested for x86_64.
>
> diff --git a/sysdeps/unix/sysv/linux/net/if_arp.h b/sysdeps/unix/sysv/linux/net/if_arp.h
> index 0f925da4f4..9ad10c37fa 100644
> --- a/sysdeps/unix/sysv/linux/net/if_arp.h
> +++ b/sysdeps/unix/sysv/linux/net/if_arp.h
> @@ -94,6 +94,8 @@ struct arphdr
>  #define ARPHRD_ROSE	270
>  #define ARPHRD_X25	271		/* CCITT X.25.  */
>  #define ARPHRD_HWX25	272		/* Boards with X.25 in firmware.  */
> +#define ARPHRD_CAN	280		/* Controller Area Network.  */
> +#define ARPHRD_MCTP	290
>  #define ARPHRD_PPP	512
>  #define ARPHRD_CISCO	513		/* Cisco HDLC.  */
>  #define ARPHRD_HDLC	ARPHRD_CISCO

This change matches the UAPI header.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/net/if_arp.h b/sysdeps/unix/sysv/linux/net/if_arp.h
index 0f925da4f4..9ad10c37fa 100644
--- a/sysdeps/unix/sysv/linux/net/if_arp.h
+++ b/sysdeps/unix/sysv/linux/net/if_arp.h
@@ -94,6 +94,8 @@  struct arphdr
 #define ARPHRD_ROSE	270
 #define ARPHRD_X25	271		/* CCITT X.25.  */
 #define ARPHRD_HWX25	272		/* Boards with X.25 in firmware.  */
+#define ARPHRD_CAN	280		/* Controller Area Network.  */
+#define ARPHRD_MCTP	290
 #define ARPHRD_PPP	512
 #define ARPHRD_CISCO	513		/* Cisco HDLC.  */
 #define ARPHRD_HDLC	ARPHRD_CISCO