From patchwork Mon Feb 6 17:48:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 724626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vHFN73FWKz9ryr for ; Tue, 7 Feb 2017 04:49:27 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="bVpefc7D"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=vP/6yUYlLx1j2/mlT5iV74VvANIeF mr6J/Ayb/xxByay7+ndc8wukfyVXq7r5prvG7uy7i9c2aisW7FzbHRJ4jKGukGyY qgpZdoOVUGs7Rhc8qIV+T/vHiI1hxiT1bnbR58O6xzbCEJK4/OlyzjJMsuniBfE4 2IPnBqk0NYUTUA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=2ZeltRtuT1cNzF532qoHNE7gALA=; b=bVp efc7DDLxd6H7aVL7Hw7RnGZcFdJCFVRL6NPULKS6IqhDMFAYzDixBzjTN1ODhu6U MG+UYzeh3eSrMxJGMVu+n79+pmnaUvDlftKp8jHIm9bp7geRYKBBHLDH12OuRmA8 ZDcPbgWuCKV6xMHlAAmTHccGDC71Aro46VeyJ4O8= Received: (qmail 31527 invoked by alias); 6 Feb 2017 17:49:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 31497 invoked by uid 89); 6 Feb 2017 17:49:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL, BAYES_50, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=libm, floating-point, floatingpoint, arose X-HELO: relay1.mentorg.com Date: Mon, 6 Feb 2017 17:48:58 +0000 From: Joseph Myers To: Subject: Remove before-compile setting in math/Makefile [committed] Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) In , Florian noted highly parallel builds being slowed down by gen-libm-test.pl running during the build, when it should only run for testing, not for building glibc itself. This is a consequence of libm-test.c being listed in before-compile. That listing in before-compile arose from the error reported in when building dependencies: at that time, dependencies were generated separation from compilation, so if a source file included a generated file it wasn't enough for the dependencies for the .o file to be correct, the generated file needed to be listed in before-compile. Since , dependencies are generated as a side-effect of compilation. This means that having the right dependencies for the .o files for the tests fully suffices to ensure that libm-test.c is generated by the time it's needed; no entry in before-compile is needed. And we indeed have such a dependency for all the tests using libm-test.c: # This must come after the inclusion of sysdeps Makefiles via Rules. $(addprefix $(objpfx), $(libm-tests.o)): $(objpfx)libm-test.stmp Thus, the before-compile definition is unnecessary, and this patch removes it. (This may of course move serialization from the glibc build to glibc testing, but I intend to split up libm-test.inc so that tests for each (floating-point type, libm function) pair are built and run separately, which should reduce that serialization.) Tested for x86_64. Committed. 2017-02-06 Joseph Myers * math/Makefile (before-compile): Remove. diff --git a/math/Makefile b/math/Makefile index 0ee4648..dd3b05a 100644 --- a/math/Makefile +++ b/math/Makefile @@ -210,9 +210,6 @@ extra-test-objs += $(addsuffix .o, $(libm-vec-test-wrappers)) libm-tests-generated = libm-test-ulps.h libm-have-vector-test.h libm-test.c generated += $(libm-tests-generated) libm-test.stmp -# This is needed for dependencies -before-compile += $(objpfx)libm-test.c - ulps-file = $(firstword $(wildcard $(sysdirs:%=%/libm-test-ulps))) $(addprefix $(objpfx), $(libm-tests-generated)): $(objpfx)libm-test.stmp