diff mbox

Make Alpha <sys/user.h> self-contained

Message ID alpine.DEB.2.20.1611041645570.25235@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Nov. 4, 2016, 4:47 p.m. UTC 
The check-installed-headers tests show up that the Alpha <sys/user.h>
is not self-contained, using size_t without including any header that
defines it.  This patch fixes it by including <stddef.h>, as done for
other architectures' versions of this header.

Tested for Alpha (compilation only).

2016-11-04  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/unix/sysv/linux/alpha/sys/user.h: Include <stddef.h>.

Comments

Joseph Myers Nov. 11, 2016, 3:02 p.m. UTC | #1 
Ping.  This patch 
<https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is pending 
review.
Carlos O'Donell Nov. 11, 2016, 7:41 p.m. UTC | #2 
On 11/11/2016 10:02 AM, Joseph Myers wrote:
> Ping.  This patch 
> <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is pending 
> review.
> 

You don't need review for this?

https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes

~~~
Anyone can commit a change adding missing #include directives where
it is clear what the right header is for functionality used in a
source file. Post the patch and ChangeLog to libc-alpha with a
short message and then push the commit. 
~~~

LGTM.
Joseph Myers Nov. 11, 2016, 9:08 p.m. UTC | #3 
On Fri, 11 Nov 2016, Carlos O'Donell wrote:

> On 11/11/2016 10:02 AM, Joseph Myers wrote:
> > Ping.  This patch 
> > <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is pending 
> > review.
> > 
> 
> You don't need review for this?
> 
> https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
> 
> ~~~
> Anyone can commit a change adding missing #include directives where
> it is clear what the right header is for functionality used in a
> source file. Post the patch and ChangeLog to libc-alpha with a
> short message and then push the commit. 

I don't think of that as applying to installed headers.
Joseph Myers Nov. 16, 2016, 6:13 p.m. UTC | #4 
Ping^2.  This patch 
<https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is still 
pending review.
Richard Henderson Nov. 17, 2016, 8:25 a.m. UTC | #5 
On 11/16/2016 07:13 PM, Joseph Myers wrote:
> Ping^2.  This patch
> <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is still
> pending review.
>

Ack.


r~
diff mbox

Patch

diff --git a/sysdeps/unix/sysv/linux/alpha/sys/user.h b/sysdeps/unix/sysv/linux/alpha/sys/user.h
index 1a7c9c4..3d0d76b 100644
--- a/sysdeps/unix/sysv/linux/alpha/sys/user.h
+++ b/sysdeps/unix/sysv/linux/alpha/sys/user.h
@@ -23,6 +23,7 @@ 
    than gdb/strace unless you know what you are doing. */
 
 #include <asm/reg.h>
+#include <stddef.h>
 
 struct user
 {