diff mbox

Fix linknamespace parallel test failures [committed]

Message ID alpine.DEB.2.20.1611032247210.20687@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Nov. 3, 2016, 10:47 p.m. UTC 
Having found that with my script to build many glibc variants I could
reproduce the linknamespace test failures in parallel builds (that
various people had previously reported but I hadn't seen myself), I
investigated those failures further.  This patch adds a missing
dependency to those tests.

Tested for x86_64, including the configuration where I saw those
failures and where I don't see them with this patch.  Committed.

2016-11-03  Joseph Myers  <joseph@codesourcery.com>

	* conform/Makefile ($(linknamespace-header-tests)): Also depend on
	$(linknamespace-symlists-tests).

Comments

Florian Weimer Nov. 4, 2016, 10:01 a.m. UTC | #1 
On 11/03/2016 11:47 PM, Joseph Myers wrote:
> 2016-11-03  Joseph Myers  <joseph@codesourcery.com>
>
> 	* conform/Makefile ($(linknamespace-header-tests)): Also depend on
> 	$(linknamespace-symlists-tests).

I tried this on a medium-to-large x86_64 machine (120 cores/240 
threads), and I had linknamespace failures before this commit, which are 
gone after it.  Thanks!

Florian
Steve Ellcey Nov. 4, 2016, 5:28 p.m. UTC | #2 
On Fri, 2016-11-04 at 11:01 +0100, Florian Weimer wrote:
> On 11/03/2016 11:47 PM, Joseph Myers wrote:
> > 
> > 2016-11-03  Joseph Myers  <joseph@codesourcery.com>
> > 
> > 	* conform/Makefile ($(linknamespace-header-tests)): Also depend
> > on
> > 	$(linknamespace-symlists-tests).
> I tried this on a medium-to-large x86_64 machine (120 cores/240 
> threads), and I had linknamespace failures before this commit, which
> are gone after it.  Thanks!
> 
> Florian

It fixed the problem for me on my aarch64 box too.  Thanks Joseph.

Steve Ellcey
diff mbox

Patch

diff --git a/conform/Makefile b/conform/Makefile
index b92a7d4..7883624 100644
--- a/conform/Makefile
+++ b/conform/Makefile
@@ -229,6 +229,7 @@  $(linknamespace-symlist-stdlibs-tests): $(objpfx)symlist-stdlibs-%: \
 
 $(linknamespace-header-tests): $(objpfx)%/linknamespace.out: \
 			       linknamespace.pl \
+			       $(linknamespace-symlists-tests) \
 			       $(linknamespace-symlist-stdlibs-tests)
 	(set -e; std_hdr=$*; std=$${std_hdr%%/*}; hdr=$${std_hdr#*/}; \
 	 mkdir -p $(@D)/scratch; \